Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout #2

Open
ulisigi opened this issue Mar 2, 2019 · 0 comments
Open

Layout #2

ulisigi opened this issue Mar 2, 2019 · 0 comments

Comments

@ulisigi
Copy link

ulisigi commented Mar 2, 2019

Your layout matches the design specification in all areas except two. The amount of space between the bottom of the featured tea images and the descriptions below should be 10px according to the design specification:
image
However, in your project, it's 20px.

The copyright section of the footer should be 20px from the left edge:
image
You included 20px of padding on the left, but the overall amount of distance is much greater:
image

Additionally, although it is not specified, there should be more space between the sections of the page. You did a nice job of matching the implicit styling found in the navigation links and the contact information, which are areas often missed by learners on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant