Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link our internal dependencies rather than installing built versions #24

Open
iandunn opened this issue Sep 5, 2022 · 4 comments
Open
Labels
devex affects developer experience

Comments

@iandunn
Copy link
Member

iandunn commented Sep 5, 2022

when one of our repos depends on another (e.g., wporg-main-2022 requires wporg-mu-plugins), the dependencies are installed w/ composer. that makes it clunky to work on both at the same time, though. you have to delete the version composer installed, and then checkout the git repo in its place. when you run composer update, the git repo gets wiped out, including any unpushed changes.

there are a few options to solve that problem, similar to npm link.

@iandunn iandunn added the devex affects developer experience label Sep 5, 2022
@iandunn
Copy link
Member Author

iandunn commented Sep 5, 2022

it may also be possible to just use composer to clone the git repos directly, rather than treating them as packages

@ocean90
Copy link
Member

ocean90 commented Sep 5, 2022

You may want to take a look at the preferred-install config. It allows you to define which type (source or dist) should be installed, either for all packages or for specific packages.

@iandunn
Copy link
Member Author

iandunn commented Sep 5, 2022

thanks!

iandunn added a commit to WordPress/wporg-main-2022 that referenced this issue Sep 13, 2022
@iandunn
Copy link
Member Author

iandunn commented Sep 13, 2022

I tried that with wporg-main-2022 and it works well for working on wporg-mu-plugins. 👍🏻

One problem on our side, though, is that Core doesn't seem to like it when trying to switch to trunk in wporg-parent-2021. It says the theme is broken because the stylesheet is missing, even though I registered an additional theme directory for the new subdir path. I'm guessing that Core sees that there isn't a stylesheet in the root folder, and doesn't try any farther.

We might be able to work around that with a filter or something, but I haven't tried yet.

iandunn added a commit to WordPress/wporg-developer that referenced this issue Sep 14, 2022
johnolson2219 pushed a commit to johnolson2219/dev_wpMed that referenced this issue Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex affects developer experience
Projects
None yet
Development

No branches or pull requests

2 participants