From 38edcaab83dc2c22d71c0ee1f5420bc7b0cacf43 Mon Sep 17 00:00:00 2001 From: benazeer1909 Date: Mon, 9 Dec 2024 12:43:07 +0530 Subject: [PATCH 1/6] site editor details text update --- packages/edit-site/src/components/post-list/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/edit-site/src/components/post-list/index.js b/packages/edit-site/src/components/post-list/index.js index 145a5e8243ac54..748c79d3979fbf 100644 --- a/packages/edit-site/src/components/post-list/index.js +++ b/packages/edit-site/src/components/post-list/index.js @@ -420,7 +420,7 @@ export default function PostList( { postType } ) { size="compact" isPressed={ quickEdit } icon={ drawerRight } - label={ __( 'Details' ) } + label={ __( 'Quick Edit' ) } onClick={ () => { history.navigate( addQueryArgs( location.path, { From 5b2c43959b6e6dbbaae5b23dcbeb742f1898ec75 Mon Sep 17 00:00:00 2001 From: benazeer1909 Date: Mon, 9 Dec 2024 15:34:10 +0530 Subject: [PATCH 2/6] Quick edit labelmin side panel --- packages/edit-site/src/components/post-edit/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/edit-site/src/components/post-edit/index.js b/packages/edit-site/src/components/post-edit/index.js index b3954e4ddbdeaf..42b9851b984f77 100644 --- a/packages/edit-site/src/components/post-edit/index.js +++ b/packages/edit-site/src/components/post-edit/index.js @@ -178,6 +178,7 @@ export function PostEdit( { postType, postId } ) { } ) } label={ __( 'Post Edit' ) } > +

{ __( 'Quick Edit' ) }

{ postId && ( ) } From 5f7a52cca37ed351c505673e095b52fdca4406d0 Mon Sep 17 00:00:00 2001 From: benazeer-ben Date: Wed, 15 Jan 2025 18:08:36 +0530 Subject: [PATCH 3/6] Feedback changes --- packages/edit-site/src/components/post-edit/index.js | 1 - .../editor/src/components/post-card-panel/index.js | 10 +++++++++- .../editor/src/components/post-card-panel/style.scss | 4 ++++ 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/packages/edit-site/src/components/post-edit/index.js b/packages/edit-site/src/components/post-edit/index.js index a5f023dbb2543a..97484c89ed670b 100644 --- a/packages/edit-site/src/components/post-edit/index.js +++ b/packages/edit-site/src/components/post-edit/index.js @@ -184,7 +184,6 @@ export function PostEdit( { postType, postId } ) { } ) } label={ __( 'Post Edit' ) } > -

{ __( 'Quick Edit' ) }

{ postId && ( ) } diff --git a/packages/editor/src/components/post-card-panel/index.js b/packages/editor/src/components/post-card-panel/index.js index 895545cb007f00..00651b88122334 100644 --- a/packages/editor/src/components/post-card-panel/index.js +++ b/packages/editor/src/components/post-card-panel/index.js @@ -7,6 +7,7 @@ import { __experimentalVStack as VStack, __experimentalText as Text, privateApis as componentsPrivateApis, + __experimentalHeading as Heading, } from '@wordpress/components'; import { store as coreStore } from '@wordpress/core-data'; import { useSelect } from '@wordpress/data'; @@ -99,6 +100,13 @@ export default function PostCardPanel( { return ( + + { __( 'Quick Edit' ) } + { title } diff --git a/packages/editor/src/components/post-card-panel/style.scss b/packages/editor/src/components/post-card-panel/style.scss index 5fa54c67f14e55..9962c77e617555 100644 --- a/packages/editor/src/components/post-card-panel/style.scss +++ b/packages/editor/src/components/post-card-panel/style.scss @@ -40,4 +40,8 @@ .editor-post-card-panel__description { color: $gray-700; } + + .editor-post-card-panel__heading { + margin-bottom: $grid-unit-20; + } } From 1610fa9d6d14da425a688af3dc4f73599127dcb2 Mon Sep 17 00:00:00 2001 From: benazeer-ben Date: Wed, 15 Jan 2025 18:34:02 +0530 Subject: [PATCH 4/6] Feedback changes - Updates limiting to edit site --- .../edit-site/src/components/post-edit/index.js | 16 ++++++++++++++-- .../src/components/post-edit/style.scss | 4 ++++ .../src/components/post-card-panel/index.js | 8 -------- .../src/components/post-card-panel/style.scss | 5 +---- 4 files changed, 19 insertions(+), 14 deletions(-) diff --git a/packages/edit-site/src/components/post-edit/index.js b/packages/edit-site/src/components/post-edit/index.js index 97484c89ed670b..30967777982e9f 100644 --- a/packages/edit-site/src/components/post-edit/index.js +++ b/packages/edit-site/src/components/post-edit/index.js @@ -10,7 +10,10 @@ import { __ } from '@wordpress/i18n'; import { DataForm } from '@wordpress/dataviews'; import { useDispatch, useSelect } from '@wordpress/data'; import { store as coreDataStore } from '@wordpress/core-data'; -import { __experimentalVStack as VStack } from '@wordpress/components'; +import { + __experimentalVStack as VStack, + __experimentalHeading as Heading, +} from '@wordpress/components'; import { useState, useMemo, useEffect } from '@wordpress/element'; import { privateApis as editorPrivateApis } from '@wordpress/editor'; @@ -185,7 +188,16 @@ export function PostEdit( { postType, postId } ) { label={ __( 'Post Edit' ) } > { postId && ( - + <> + + { __( 'Quick Edit' ) } + + + ) } { ! postId &&

{ __( 'Select a page to edit' ) }

} diff --git a/packages/edit-site/src/components/post-edit/style.scss b/packages/edit-site/src/components/post-edit/style.scss index 5688d83df00c5f..f17edf00db24bf 100644 --- a/packages/edit-site/src/components/post-edit/style.scss +++ b/packages/edit-site/src/components/post-edit/style.scss @@ -6,6 +6,10 @@ align-items: center; justify-content: center; } + + .editor-post-card-panel__heading { + margin-bottom: $grid-unit-20; + } } .dataforms-layouts-panel__field-dropdown { diff --git a/packages/editor/src/components/post-card-panel/index.js b/packages/editor/src/components/post-card-panel/index.js index 00651b88122334..b8c90ca6e9e3ca 100644 --- a/packages/editor/src/components/post-card-panel/index.js +++ b/packages/editor/src/components/post-card-panel/index.js @@ -7,7 +7,6 @@ import { __experimentalVStack as VStack, __experimentalText as Text, privateApis as componentsPrivateApis, - __experimentalHeading as Heading, } from '@wordpress/components'; import { store as coreStore } from '@wordpress/core-data'; import { useSelect } from '@wordpress/data'; @@ -100,13 +99,6 @@ export default function PostCardPanel( { return ( - - { __( 'Quick Edit' ) } - Date: Wed, 15 Jan 2025 19:18:29 +0530 Subject: [PATCH 5/6] lint update --- packages/editor/src/components/post-card-panel/style.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/editor/src/components/post-card-panel/style.scss b/packages/editor/src/components/post-card-panel/style.scss index e286b9b9afc094..5fa54c67f14e55 100644 --- a/packages/editor/src/components/post-card-panel/style.scss +++ b/packages/editor/src/components/post-card-panel/style.scss @@ -41,4 +41,3 @@ color: $gray-700; } } - From afb7072ff04df79eb9c44fd3967ab66f3814c0f2 Mon Sep 17 00:00:00 2001 From: benazeer-ben Date: Fri, 17 Jan 2025 17:10:19 +0530 Subject: [PATCH 6/6] Feedback changes --- .../src/components/post-edit/index.js | 18 +++--------------- .../src/components/post-edit/style.scss | 11 +++-------- 2 files changed, 6 insertions(+), 23 deletions(-) diff --git a/packages/edit-site/src/components/post-edit/index.js b/packages/edit-site/src/components/post-edit/index.js index 30967777982e9f..5ed77d1e8551ed 100644 --- a/packages/edit-site/src/components/post-edit/index.js +++ b/packages/edit-site/src/components/post-edit/index.js @@ -10,10 +10,7 @@ import { __ } from '@wordpress/i18n'; import { DataForm } from '@wordpress/dataviews'; import { useDispatch, useSelect } from '@wordpress/data'; import { store as coreDataStore } from '@wordpress/core-data'; -import { - __experimentalVStack as VStack, - __experimentalHeading as Heading, -} from '@wordpress/components'; +import { __experimentalVStack as VStack } from '@wordpress/components'; import { useState, useMemo, useEffect } from '@wordpress/element'; import { privateApis as editorPrivateApis } from '@wordpress/editor'; @@ -185,19 +182,10 @@ export function PostEdit( { postType, postId } ) { className={ clsx( 'edit-site-post-edit', { 'is-empty': ! postId, } ) } - label={ __( 'Post Edit' ) } + title={ __( 'Quick Edit' ) } > { postId && ( - <> - - { __( 'Quick Edit' ) } - - - + ) } { ! postId &&

{ __( 'Select a page to edit' ) }

} diff --git a/packages/edit-site/src/components/post-edit/style.scss b/packages/edit-site/src/components/post-edit/style.scss index f17edf00db24bf..1408958260bfdd 100644 --- a/packages/edit-site/src/components/post-edit/style.scss +++ b/packages/edit-site/src/components/post-edit/style.scss @@ -1,14 +1,9 @@ .edit-site-post-edit { padding: $grid-unit-30; - &.is-empty .edit-site-page-content { - display: flex; - align-items: center; - justify-content: center; - } - - .editor-post-card-panel__heading { - margin-bottom: $grid-unit-20; + .edit-site-page-header { + padding: 10px 0; + border-bottom: none; } }