Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PhpParser dependency #70

Closed
reimic opened this issue Mar 11, 2024 · 1 comment
Closed

Remove PhpParser dependency #70

reimic opened this issue Mar 11, 2024 · 1 comment
Labels
enhancement New feature or request V1
Milestone
Shape PHP Blueprint

Comments

@reimic
Copy link
Collaborator

reimic commented Mar 11, 2024

The reimplemented Jason Mapper uses less dependencies than before and works well with PHP 7.0 and up. Yet, we can still reduce more.

One of the things to consider is the PhpParser. It looks as if we could drop in in favor of reimplementation or a smaller dependency. Let's look into that.

This package is 250kb zipped. It's fine for this PR but let's explore switching to something lightweight like token_get_all() before shipping v1 of this library. Would you please start an issue to track that?
Originally posted by @adamziel in WordPress/blueprints#69 (comment)
@reimic reimic added enhancement New feature or request V1 labels Mar 11, 2024
@reimic reimic added this to the Shape PHP Blueprint milestone Mar 11, 2024
@reimic reimic mentioned this issue Mar 11, 2024
Merged
@adamziel adamziel changed the title Blueprints: reducing dependencies load Blueprints: Remove PhpParser dependency Mar 13, 2024
@adamziel adamziel changed the title Blueprints: Remove PhpParser dependency Remove PhpParser dependency Mar 13, 2024
@reimic
Copy link
Collaborator Author

reimic commented Mar 26, 2024

The reimplemented Json Mapper does not use the PhpParser. Other dependencies were ported in #77 and also do not require its presence.

@reimic reimic closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request V1
Projects
Playground Board
Archived in project
Milestone
Shape PHP Blueprint
Development

No branches or pull requests
1 participant
@reimic