Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical lighting problems #351

Open
fire opened this issue Nov 26, 2023 · 1 comment
Open

Physical lighting problems #351

fire opened this issue Nov 26, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@fire
Copy link
Member

fire commented Nov 26, 2023

Issue description

Saracen discovered that lighting is blown out. That's because of the physical light units setting in the project settings, and presumably because the uploaded maps didn't use it (if that can be changed at runtime, it might be possible to add physical light units as a per map feature flag, but not sure if that's possible.)

iFire modified V-Sekai-game so the physical light units are in the xr_origin tscns.

Steps to reproduce

  1. Load the cc0hut.

The Tokyo map, the haven, the concrete test map and desert light are fine.

Minimal reproduction project (For SDK or engine issues)

N/A

Use the game project.

Using a released version?

no

What OS? Any other relevant information? (V-Sekai version, Godot revision, System information)

Windows 11 Nvidia

@fire fire added the bug Something isn't working label Nov 26, 2023
@fire
Copy link
Member Author

fire commented Nov 26, 2023

I think we can reupload the cc0 hut to fix the lighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants