Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blend shape fixes for VRM1 #95

Open
fire opened this issue Jan 23, 2024 · 2 comments
Open

Blend shape fixes for VRM1 #95

fire opened this issue Jan 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@fire
Copy link
Member

fire commented Jan 23, 2024

From Lyuma

  1. not all vrm1 files will hit the head hiding code
  2. some models may explicitly assign the face mesh to be thirdPersonOnly
  3. some cases exist in which the same mesh will be returned
  4. need to do the blendshape names in a separate step
@lyuma
Copy link
Member

lyuma commented Jan 24, 2024

To summarize:

#94 was merged with support for the vrm-specific mesh/primitives/extras/targetNames property in the vrm 0 rotate_scene_180 function. we should document that this function also renames blendshape names

However, this code does not get hit in vrm 1.0, and there was a duplicate of this put into the face hiding code which is both redundant in vrm 0 but isn't guaranteed to be hit in vrm 1 for all meshes (with firstPersonMode!="auto"), so we should fix this at some point.

@fire fire added the bug Something isn't working label Sep 28, 2024
@fire
Copy link
Member Author

fire commented Oct 14, 2024

We discussed cutting a release after adding a export option for head hiding code and default it to off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants