Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wrap parameter for OptionList no longer works #5418

Open
davep opened this issue Dec 21, 2024 · 0 comments
Open

The wrap parameter for OptionList no longer works #5418

davep opened this issue Dec 21, 2024 · 0 comments

Comments

@davep
Copy link
Contributor

davep commented Dec 21, 2024

Starting in July 2023 (cb819fa ) OptionList has had a parameter to control if options should auto-wrap or not. As of Textual 1.0 it would appear that this parameter is now a no-op. Setting it to False has no effect and, after a brief look at the OptionList code, I can't see the value being actually used any more.

This will also affect SelectionList as it is designed to work as a non-wrapping descendent of OptionList.

This does, of course, potentially break the layout of any application that is relying on an OptionList that truncates rather than wraps its Options.

A quick jog back through the blame history suggests that the regression started around here: 1a5fbb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant