From 571315b757a357a250e26b13b8eca668416b7415 Mon Sep 17 00:00:00 2001 From: frontier159 <103474701+frontier159@users.noreply.github.com> Date: Fri, 20 Oct 2023 17:28:43 +1100 Subject: [PATCH] chore: enable slither --- .github/workflows/slither.yaml | 2 +- protocol/foundry.toml | 1 + protocol/slither.db.json | 10 ++++++++++ protocol/test/forge/v2/strategies/RamosStrategy.t.sol | 2 +- 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/.github/workflows/slither.yaml b/.github/workflows/slither.yaml index 200e2b972..0f4a3bb7e 100644 --- a/.github/workflows/slither.yaml +++ b/.github/workflows/slither.yaml @@ -10,7 +10,7 @@ on: - ".github/workflows/slither.yaml" jobs: analyze: - if: ${{ false }} # Slither has an issue with prb math, and is super slow... + # if: ${{ false }} # Slither has an issue with prb math, and is super slow... runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 diff --git a/protocol/foundry.toml b/protocol/foundry.toml index b182ae959..d67e97898 100644 --- a/protocol/foundry.toml +++ b/protocol/foundry.toml @@ -8,6 +8,7 @@ test = 'test/forge' cache_path = 'cache-foundry' gas_reports = ["*"] + evm_version = "paris" # See https://www.evmdiff.com/features?name=PUSH0&kind=opcode [profile.ci] fuzz = { runs = 5000 } diff --git a/protocol/slither.db.json b/protocol/slither.db.json index aa221dd98..71dffe7fd 100644 --- a/protocol/slither.db.json +++ b/protocol/slither.db.json @@ -1,4 +1,14 @@ [ + { + "elements": [], + "description": "solc-0.8.21 is not recommended for deployment\n", + "markdown": "solc-0.8.21 is not recommended for deployment\n", + "first_markdown_element": "", + "id": "d89306001b1fa2ce11230334eb8b32e1ae6da7490b6d2bb2daf2e369120bbacf", + "check": "solc-version", + "impact": "Informational", + "confidence": "High" + }, { "elements": [ { diff --git a/protocol/test/forge/v2/strategies/RamosStrategy.t.sol b/protocol/test/forge/v2/strategies/RamosStrategy.t.sol index 2383adb7b..aa1f08ad3 100644 --- a/protocol/test/forge/v2/strategies/RamosStrategy.t.sol +++ b/protocol/test/forge/v2/strategies/RamosStrategy.t.sol @@ -216,7 +216,7 @@ contract RamosStrategyTestAdmin is RamosStrategyTestBase { assertEq(strategy.rescuer(), rescuer); assertEq(strategy.apiVersion(), "1.0.0"); assertEq(strategy.strategyName(), "RamosStrategy"); - assertEq(strategy.strategyVersion(), "1.0.0"); + assertEq(strategy.strategyVersion(), "1.0.1"); assertEq(address(strategy.treasuryReservesVault()), address(trv)); assertEq(address(strategy.quoteToken()), address(dai)); ITempleStrategy.AssetBalanceDelta[] memory adjs = strategy.manualAdjustments();