Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to update workflow #219

Open
4 tasks
vinicvaz opened this issue Jan 26, 2024 · 1 comment
Open
4 tasks

Allow users to update workflow #219

vinicvaz opened this issue Jan 26, 2024 · 1 comment
Assignees
Labels
domino-py Domino Python package related issues enhancement New feature or request frontend Frontend related issues REST REST API related issues

Comments

@vinicvaz
Copy link
Collaborator

We should think the best way for editing workflows.

At the first moment I see 2 options:

1. Recreating the workflow (like a PUT operation)

Pros:

  • It is easier to implement, we should only override / recreate all the dag file content and keep the reference to it on our database.
    Cons:
  • Despite it be a update, the user can't "undo" and go back to the "creation" state. The update would "create" a new workflow with the new data.
  • Users would need to wait for dag sync until can run the workflow. I can be annoying with slow git sync sometimes.

2. Updating workflow input arguments using dag config to inject new data into the template.

Pros:

  • Users can run an already created workflow with custom inputs without the need of creating a new one, would be a "edit and run" experience. It would make the experience of creating / editing / testing workflows much more fast, intuitive and productive.
  • The first state of the saved workflow are keep in database so if the user edit it and don't like the results it is not saved, the new inputs are running only in the specific manual triggered run.
  • We can still have the first option, but only when user decide to save the edited workflow with the new configuration parameters.
    Cons:
  • It is harder to implement since we will need to update how we are injecting arguments into the dag template.

Necessary changes:

  • Add button to workflows list table that redirect user to the editor page with the workflow data.
  • Create patch endpoint for updating workflows.

Possible/Probably changes:

  • Update workflow Jinja template to accept inputs as variables
  • Update how we inject data into each workflow
@vinicvaz vinicvaz self-assigned this Jan 26, 2024
@vinicvaz
Copy link
Collaborator Author

@luiztauffer @nathan-vm @tdari FYI

@vinicvaz vinicvaz added enhancement New feature or request frontend Frontend related issues REST REST API related issues domino-py Domino Python package related issues labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domino-py Domino Python package related issues enhancement New feature or request frontend Frontend related issues REST REST API related issues
Projects
None yet
Development

No branches or pull requests

2 participants