Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does anyone know how to use the value minResolution in textures.json ? #4000

Open
sunshuwei opened this issue Dec 7, 2024 · 6 comments
Open
Labels
question Just a question, no change in code needed

Comments

@sunshuwei
Copy link
Contributor

sunshuwei commented Dec 7, 2024

The User Guide did not explain this clearly, and I did not find any effect after modifying the value.

User Guide: “minResolution UNDOCUMENTED VALUE!”
Does it mean that this is an arbitrary value?

@gzotti
Copy link
Member

gzotti commented Dec 7, 2024

No. It just means that the first team who have introduced this value (2007-09?) have not explained what they did in code comments for the MultiLevelJsonBase and StelSkyImageTile classes and and, we, the current team, have not reverse-engineered the exact internals of the StelSkyImageTile class to understand all the details that went into developing these important classes. If you can, please find out, and when you are sure, add documentation. I am sure there is a meaning in this.

It is not completely undocumented, though. In StelSkyImageTile.hpp we find:

//! Minimum resolution of the data of the texture in degree/pixel

But I did not follow up to the end what depends on it.

@10110111
Copy link
Contributor

10110111 commented Dec 7, 2024

Looks like it's the resolution when the next-level tiles should be shown, see this part of the code.

@gzotti
Copy link
Member

gzotti commented Dec 7, 2024

Ah, right. Is this then relevant for DSS/HiPS only, or are our DSO textures also structured in this way (or are the overlapping DSO images in the DSO images issue thread a result of negligence of correctly configuring this value in the JSON?) I had the impression these classes were made to allow more than is now used. (e.g. what is dataSetCredits for?)

@gzotti
Copy link
Member

gzotti commented Dec 7, 2024

And if this is property of the actual texture, why is it called minResolution, not just resolution?

@10110111
Copy link
Contributor

10110111 commented Dec 7, 2024

I don't know how the DSO textures are structed, but judging by the locations of the overlapping DSO images I suppose that they won't align well with HiPS tiles.

And if this is property of the actual texture, why is it called minResolution, not just resolution?

It's the minimum "resolution" of the display after which tiles are switched. The "resolution" word here is a misnomer, since it's a reciprocal of the actual resolution: the larger the value, the poorer the image.

@alex-w alex-w added the question Just a question, no change in code needed label Dec 7, 2024
@sunshuwei
Copy link
Contributor Author

Whether it represents the arc represented by each pixel in the image, also known as pixel scale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Just a question, no change in code needed
Development

No branches or pull requests

4 participants