Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable start positions for flow domain in SophT #157

Open
armantekinalp opened this issue Aug 30, 2023 · 3 comments
Open

Variable start positions for flow domain in SophT #157

armantekinalp opened this issue Aug 30, 2023 · 3 comments
Labels
enhancement New feature or request prio:medium Medium priority

Comments

@armantekinalp
Copy link
Collaborator

Currently Sopht only allows the flow domain to start at (0,0,0) . We should update such that user can start the domain at any point in space. We need to carefully see all the ImmersedBoundary interpolation kernels and update where ever we use flow domain grid positions.

@armantekinalp armantekinalp added enhancement New feature or request prio:medium Medium priority labels Aug 30, 2023
@fankiat
Copy link
Collaborator

fankiat commented Aug 31, 2023

FWIW, you may find it helpful (hopefully) that some of this logic is implemented in sopht-mpi ImmersedBoundary interpolation kernels, since each of the subdomain technically has a different domain start. 😃

@armantekinalp
Copy link
Collaborator Author

That is a very good idea. @fankiat if there is any related file can you share the link here to get started.

@fankiat
Copy link
Collaborator

fankiat commented Aug 31, 2023

The related files that I can think of at the top of my head now should be in the numeric/immersed_boundary_ops. For example, the function here takes in an argument mpi_local_substart_coord_shift, which I guess would be the start position of your Eulerian mesh. The variable should be obtained upstream from the simulator when a user prescribes the Eulerian origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:medium Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants