Time overlap errors are not added to the first harvest item during metadata review

[hudson-newey]

If two audio recordings overlap times and are uploaded to the same site, the baw-server should reject both of the files.

However, during metadata review the first file will not be rejected.

Note: All files will be correctly rejected during processing

---

1. The metadata is extracted from the first audio file
2. The metadata is analyzed, and no overlaps are found from the first file
3. The metadata is extracted from the second audio file
4. The metadata is analyzed, and an overlap is found with the first files metadata. But the first harvest item fails to update with the new error

---

The processing stage is not effected because the metadata from the metadata extraction stage is still available.

How to reproduce

1. Upload two audio files that have time overlaps and are applied to the same site
2. Change the status to metadata review
3. Observe that only the second file was rejected, when both files should have been rejected

[atruskie]

Notes:

• this happens when there is not sufficient data populated into all relevant harvest items
• it particularly prevalent when doing a "recheck" after a mapping stage
• i thought this might have been some kind of race condition, not sure where it is happening though
• the problem is when the checks for overlaps (or duplicates for that matter is done) depends on what data has been committed to the database. And that can be moving depending on the state of the transactions.

Potential solutions:

• we need a stage of the harvest that does validation checks that depends on more than one audio recording to happen when all metadata has been extract and the harvest is stable
• or less complex, but more dirty: we need to update the affected overlapping recordings when an overlap is detected