Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move styles off of compiled HTML and into the prendus-view-question component #21

Open
lastmjs opened this issue Jul 8, 2017 · 1 comment

Comments

@lastmjs
Copy link
Member

lastmjs commented Jul 8, 2017

I think it makes sense to keep the compiled HTML as simple as possible, and that means having minimal to no styling. I think the styling should be left up to the consumer of the compiled HTML, the interpreter. The Prendus question components are a consumer. I ran into a problem while taking off the styling, and I believe it is because of the Shadow DOM polyfill in Firefox. Until Firefox and Edge ship native implementations of Shadow DOM for at least 2 or 3 browser versions, I wouldn't try to put the styles on in the consumer component. But once we can, we should move the styles.

@lastmjs lastmjs added this to the Potential Features milestone Jul 8, 2017
@lastmjs
Copy link
Member Author

lastmjs commented Nov 11, 2017

Might not be a good idea, we probably want the AST to have some style information in it, for example to size images and essays and code editors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant