Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]CA_IsPlayerInWater #38

Open
Romz24 opened this issue Jan 9, 2018 · 3 comments
Open

[bug]CA_IsPlayerInWater #38

Romz24 opened this issue Jan 9, 2018 · 3 comments

Comments

@Romz24
Copy link
Contributor

Romz24 commented Jan 9, 2018

Why is there no check for the height of the water? There is a place where the water is high in the sky, but when I'm on the ground the function thinks I'm in the water. Can you make a correction?

Coordinates:
1283.7430, -776.9374, 96.4609

water

@Romz24
Copy link
Contributor Author

Romz24 commented Jan 9, 2018

Here is another place where water is not properly determined.
222.9651, -1198.2930, 21.7121

sa-mp-030

@Crayder
Copy link
Collaborator

Crayder commented Jan 9, 2018

We can't exactly check for the height right now.

https://github.com/Pottus/ColAndreas/blob/master/Server/include/colandreas.inc#L829

On that line we add and subtract 1000 from the players position. ColAndreas only knows where the water planes are, they don't include the height of their water effects.

@Romz24
Copy link
Contributor Author

Romz24 commented Jan 9, 2018

I'm currently getting a lot of mistakes in my game mode because of this. Why do not you want to add a height to the total array for each water and check for it?
https://github.com/Pottus/ColAndreas/blob/master/src/WaterArray.h

Please do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants