-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph scaling for F and K #202
Comments
This is in function.cpp. When the graph is reset the following code is executed.
This will make lower bound always be 25, but not necessarily 25 C. This is just 25 of whatever unit we have. If we then switch to Kelvin or Fahrenheit the lowest point on the graph will still be 25 K or 25 F respectively. I can probably figure out a way around this. Ultimately thought, implementing a sliding temperature axis based on the total on-screen temperature range will solve this and be the proper implementation. I think in the updateGraph() function I will have to write some code to scan through the current readings and find the min and max values, then adjust the temperature axis. |
It would also be nice if the user could manually set the upper and lower bounds, to lock the range displayed. The probe numbers on the right of the screen could show a "+" beside them and be pinned at the top, or a "-" and be pinned at the bottom, for temperatures out of range. Or alternatively, instead of "+" or "-" use arrows or triangle pointers "▲" or "▼". It would be desirable to indicate that you are in fixed range mode. Perhaps change the graph "tick", to the right of the upper and lower bounds values, to a triangle pointer "►". Deciding on the buttons used to control this would be a challenge. Perhaps make it work like many digital watches and timers do:
It would be nice to have the values auto increment/decrement if record/time were held down. To return to auto scale mode:
If you wanted to support selecting thermocouple types, as suggested in issue #200, you could have pressing the graph button switch types when either range value is flashing. |
@protological can we close this now that #219 is merged into master? |
Yes, scaling works |
"When in Celsius mode, the display properly scales the vertical scale to show all four probes with maximum vertical resolution. However, it doesn't seem to do that on Fahrenheit or Kelvin leaving plenty of unneeded "white" space on the bottom of the screen making the display vertical resolution not nearly as good as the Celsius mode." -Eirc
The text was updated successfully, but these errors were encountered: