New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default mysql user info should be used consistently #4

Open

keithbentrup opened this issue Aug 20, 2020 · 0 comments

Member

keithbentrup commented Aug 20, 2020

currently the default built docker-compose.yaml uses

environment:
      - MYSQL_ROOT_PASSWORD=magento2
      - MYSQL_DATABASE=magento2
      - MYSQL_USER=magento2
      - MYSQL_PASSWORD=magento2

but .magento.env.yaml may look like

environment:
      - MYSQL_DATABASE=main
      - MYSQL_USER=user
      - MYSQL_PASSWORD=

currently there are multiple places where there can be mismatched values

the generated docker-compose.yaml
the .magento.env.yaml from the project
the dockerize script that attempts to create a .magento.env.yaml file
the menu items install_app handler when accounting for Running setup:config:set doesn't just update, but also deletes values, running it a second time fixes it (kind of) magento/magento2#2852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment