Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate token if not taken in step #117

Open
Toxantron opened this issue Jul 13, 2021 · 0 comments
Open

Duplicate token if not taken in step #117

Toxantron opened this issue Jul 13, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Toxantron
Copy link
Member

Is your feature request related to a problem? Please describe.
When implementing a WorkplanTransition I just called PlaceToken, but forgot to call TakeToken for the sender. This creates a duplicate which causes issues if the workplan is saved and restored.

I know why the API is that way, but unless you do this daily it's quite easy to forget.

Describe the solution you'd like
Either a dedicated method to move the token from Input to correct output or a check within PlaceToken if an input still holds the token.

Describe alternatives you've considered

Additional context

@Toxantron Toxantron added the enhancement New feature or request label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant