Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP Search window is broken on Windows10/Firefox #65

Open
iramcdonald opened this issue Oct 9, 2019 · 3 comments
Open

OP Search window is broken on Windows10/Firefox #65

iramcdonald opened this issue Oct 9, 2019 · 3 comments

Comments

@iramcdonald
Copy link
Collaborator

On my Windows 10 machine w/ Firefox (with ad blocking
disabled), the Search window is still broken.

Enter/Return does nothing.

There should be an explicit Submit button added.

@dheeraj135
Copy link
Member

Hi @iramcdonald, I looked into this. If we want to make the search work, we need to setup algolia and it looks a little bit time-consuming. When we get student contributors, we can float this as an assignment.

@iramcdonald
Copy link
Collaborator Author

iramcdonald commented Dec 11, 2019 via email

@dheeraj135
Copy link
Member

@iramcdonald Algolia is free for the community. The free edition offers up to 50k searches each month. This is more than enough for OP.
We cannot use elastic search because the elastic search requires a server to run on. Our website is hosted on GitHub pages. The old OpenPrinting server runs on Ubuntu 12.04, so it will be very difficult to port current versions of elastic search to a 7 year OS.
So, I believe we should stick to Algolia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants