Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycharm_downloads_path #8

Open
AiyionPrime opened this issue Oct 13, 2020 · 3 comments
Open

pycharm_downloads_path #8

AiyionPrime opened this issue Oct 13, 2020 · 3 comments
Labels

Comments

@AiyionPrime
Copy link

AiyionPrime commented Oct 13, 2020

As pycharm_downloads_path it has a precedence of 15, right?

How do you overwrite this value properly?
And why did you choose to put it as var instead of a default at all?

It appears to be weird to store a potentially large amount of pycharm archives relatively deeply nested in /var.
Even more if it's not the ansible home.

I'd suppose you either make this easier to overwrite, or use the ansible fact "ansible_user_dir".

Either way, this plugin appears to be really nice and I'm looking forward to using it.
Thanks for the effort!

@tersmitten
Copy link
Member

tersmitten commented Oct 26, 2020

As pycharm_downloads_path it has a precedence of 15, right?

Yes

How do you overwrite this value properly?

You're not, this was never intended

It appears to be weird to store a potentially large amount of pycharm archives relatively deeply nested in /var

All our Ansible roles (150+) use /var/lib/ansible/ROLE/* for their downloads, builds et cetera. That's something we picked a long time ago

@AiyionPrime
Copy link
Author

And the part /var/lib/ansible/ is your ansibles home directory?
Or not necessarily?

If so, would you be open for a pull request making use of the home directory fact?

@AiyionPrime
Copy link
Author

I think that answered the last question.
The two ones before did only matter to me until I submitted #9 ,
unless you don't change your mind about how this would improve the role, all my questions are answered.

Thanks for your time and the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants