Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept data does not get exported in incremental mode in certain situations #907

Open
gowthamrao opened this issue Aug 21, 2022 · 1 comment

Comments

@gowthamrao
Copy link
Member

In current workflow, concept set details (especially concept table) is download as the last step. This creates scenarios when this data is not extracted.

To reproduce:

  1. Run Cohort Diagnostics with default parameters in incremental mode
  2. When concept set diagnostics is complete (for example when incidence rate is computed) interrupt and terminate the job
  3. Restart in incremental mode

No concept table is extracted. This is because resolved concepts is temporary table

@gowthamrao
Copy link
Member Author

This is a less optimal design especially when CohortDiagnostics is running large jobs such as phenotype library. Interruptions happen, then on resumption - no concept table is extracted.

The reason for the separation in the past is to extract the concepts that are part of visit_context diagnostics.

Potential solution: There are certain concepts that we may consider to be always needed. e.g. concepts in visit domain, gender domain. We can either extract them all as default for every project, or keep a copy of these extremely small csv files in inst folder of package. That way, we do not need to extract concepts during visit context, and all concept ids that need to be extracted are extracted during concept set diagnostics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant