From 33edb88da432fb39dc0f9676f7d33066c80ff5af Mon Sep 17 00:00:00 2001
From: Kushal Harish Naidu <kushal.harish.naidu@ericsson.com>
Date: Thu, 7 Mar 2024 12:25:06 +0000
Subject: [PATCH] update E2E unit tests for porch cli

Signed-off-by: Kushal Harish Naidu <kushal.harish.naidu@ericsson.com>
---
 test/e2e/cli/testdata/rpkg-copy/config.yaml      |  4 ++--
 test/e2e/cli/testdata/rpkg-lifecycle/config.yaml | 16 ++++++++--------
 test/e2e/cli/testdata/rpkg-push/config.yaml      |  1 +
 test/e2e/cli/testdata/rpkg-update/config.yaml    |  5 +++--
 4 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/test/e2e/cli/testdata/rpkg-copy/config.yaml b/test/e2e/cli/testdata/rpkg-copy/config.yaml
index 94e10e7f..5e90830c 100644
--- a/test/e2e/cli/testdata/rpkg-copy/config.yaml
+++ b/test/e2e/cli/testdata/rpkg-copy/config.yaml
@@ -24,14 +24,14 @@ commands:
       - propose
       - --namespace=rpkg-copy
       - git-eb5afe755bedd142f142c6a9363649c667ef77a5
-    stderr: "git-eb5afe755bedd142f142c6a9363649c667ef77a5 proposed\n"
+    stdout: "git-eb5afe755bedd142f142c6a9363649c667ef77a5 proposed\n"
   - args:
       - porchctl
       - rpkg
       - approve
       - --namespace=rpkg-copy
       - git-eb5afe755bedd142f142c6a9363649c667ef77a5
-    stderr: "git-eb5afe755bedd142f142c6a9363649c667ef77a5 approved\n"
+    stdout: "git-eb5afe755bedd142f142c6a9363649c667ef77a5 approved\n"
   - args:
       - porchctl
       - rpkg
diff --git a/test/e2e/cli/testdata/rpkg-lifecycle/config.yaml b/test/e2e/cli/testdata/rpkg-lifecycle/config.yaml
index 8d5b7cae..d560517f 100644
--- a/test/e2e/cli/testdata/rpkg-lifecycle/config.yaml
+++ b/test/e2e/cli/testdata/rpkg-lifecycle/config.yaml
@@ -21,7 +21,7 @@ commands:
       - propose
       - --namespace=rpkg-lifecycle
       - git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034
-    stderr: |
+    stdout: |
       git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034 proposed
   - args:
       - porchctl
@@ -50,7 +50,7 @@ commands:
       - reject
       - --namespace=rpkg-lifecycle
       - git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034
-    stderr: |
+    stdout: |
       git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034 rejected
   - args:
       - porchctl
@@ -78,7 +78,7 @@ commands:
       - propose
       - --namespace=rpkg-lifecycle
       - git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034
-    stderr: |
+    stdout: |
       git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034 proposed
   - args:
       - porchctl
@@ -95,7 +95,7 @@ commands:
       - approve
       - --namespace=rpkg-lifecycle
       - git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034
-    stderr: |
+    stdout: |
       git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034 approved
   - args:
       - porchctl
@@ -123,7 +123,7 @@ commands:
       - propose-delete
       - git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034
       - --namespace=rpkg-lifecycle
-    stderr: |
+    stdout: |
       git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034 proposed for deletion
   - args:
       - porchctl
@@ -148,7 +148,7 @@ commands:
       - reject
       - git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034
       - --namespace=rpkg-lifecycle
-    stderr: |
+    stdout: |
       git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034 no longer proposed for deletion
   - args:
       - porchctl
@@ -176,7 +176,7 @@ commands:
       - propose-delete
       - git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034
       - --namespace=rpkg-lifecycle
-    stderr: |
+    stdout: |
       git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034 proposed for deletion
   - args:
       - porchctl
@@ -193,7 +193,7 @@ commands:
       - delete
       - git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034
       - --namespace=rpkg-lifecycle
-    stderr: |
+    stdout: |
       git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034 deleted
   - args:
       - porchctl
diff --git a/test/e2e/cli/testdata/rpkg-push/config.yaml b/test/e2e/cli/testdata/rpkg-push/config.yaml
index 65dc6d60..2effb864 100644
--- a/test/e2e/cli/testdata/rpkg-push/config.yaml
+++ b/test/e2e/cli/testdata/rpkg-push/config.yaml
@@ -136,6 +136,7 @@ commands:
       - --namespace=rpkg-push
       - git-efe3d01c68dfdcdd69114c9a7c65cce0d662a46f
       - /tmp/porch-e2e/rpkg-push-git-efe3d01c68dfdcdd69114c9a7c65cce0d662a46f
+    stdout: "git-efe3d01c68dfdcdd69114c9a7c65cce0d662a46f pushed\n"
   - args:
       - porchctl
       - rpkg
diff --git a/test/e2e/cli/testdata/rpkg-update/config.yaml b/test/e2e/cli/testdata/rpkg-update/config.yaml
index 9288dc2d..67158872 100644
--- a/test/e2e/cli/testdata/rpkg-update/config.yaml
+++ b/test/e2e/cli/testdata/rpkg-update/config.yaml
@@ -45,14 +45,14 @@ commands:
       - propose
       - --namespace=rpkg-update
       - git-7fcdd499f0790ac3bd8f805e3e5e00825641eb60
-    stderr: "git-7fcdd499f0790ac3bd8f805e3e5e00825641eb60 proposed\n"
+    stdout: "git-7fcdd499f0790ac3bd8f805e3e5e00825641eb60 proposed\n"
   - args:
       - porchctl
       - rpkg
       - approve
       - --namespace=rpkg-update
       - git-7fcdd499f0790ac3bd8f805e3e5e00825641eb60
-    stderr: "git-7fcdd499f0790ac3bd8f805e3e5e00825641eb60 approved\n"
+    stdout: "git-7fcdd499f0790ac3bd8f805e3e5e00825641eb60 approved\n"
   - args:
       - porchctl
       - rpkg
@@ -139,6 +139,7 @@ commands:
       - --namespace=rpkg-update
       - git-7ab0219ace10c1081a8b40a6b97d5da58bdb62e0
       - /tmp/porch-e2e/pkg-update-git-7ab0219ace10c1081a8b40a6b97d5da58bdb62e0
+    stdout: "git-7ab0219ace10c1081a8b40a6b97d5da58bdb62e0 pushed\n"
   - args:
       - porchctl
       - rpkg