Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.X iPhone X Unsupported #55

Open
joeldhenry opened this issue Jul 2, 2019 · 3 comments
Open

v4.X iPhone X Unsupported #55

joeldhenry opened this issue Jul 2, 2019 · 3 comments
Assignees

Comments

@joeldhenry
Copy link

the view is stretched, and makes the plugin unusable on iPhone X

https://github.com/charlymr/IRLDocumentScanner/issues/29

@joeldhenry joeldhenry changed the title iPhone X Unsupported v4.X iPhone X Unsupported Jul 2, 2019
@ChrisTomAlx ChrisTomAlx self-assigned this Jul 8, 2019
@ChrisTomAlx
Copy link
Collaborator

Hey @joeldhenry

Thanks for raising this issue. Also thanks for linking the issue to the original library. I have requested some help from the original library creator, but I guess he is too busy, so I will look into this as and when I am able to.

Cheers!
Chris
Neutrinos

@Suzzak
Copy link

Suzzak commented Aug 28, 2019

Same problem with iOS but I take the opportunity to tell you that your plugin is incredibly effective, I love it. Thanks to you!

@MimoGraphix
Copy link

Hi @ChrisTomAlx

I think I was able to fix this issue. Problem is that iOS is capturing photos in ratio 4:3 but ImageView in the plugin is scaling the image to the full view

Changes I made are simple:
IRLCameraView.m:~152 ->
UIImageView *view = [[UIImageView alloc] initWithFrame:self.bounds];
view.transform = CGAffineTransformMakeScale(1.0f, 0.75f); // this is what I added which is basically transforming image to 4:3 scale

and the same one I used in

IRLCameraView.m:~218 ->
GLKView *view = [[GLKView alloc] initWithFrame:self.bounds];
view.transform = CGAffineTransformMakeScale(1.0f, 0.75f);

Please let me know if this fix worked also for you...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants