You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Both of these GitHub issue objects were bundles of multiple actual issues. Neither was addressed, and #67 had a comment that, while true, omitted the rest of the concerns being raised by the creator. If other commenters had continued to address just part of the concerns, the ticket might have been closed without addressing all the underlying problems. I've seen this happen in open-source projects.
Suggested Improvements:
On the one hand, when we create GitHub Issue objects, we should be careful to create coherent documents addressing well-scoped concerns rather than bundles that include many concerns.
However, we don't always perceive that the items we discuss should be separated. So, when we notice issues that involve several concerns, we should break them up into individual GitHub Issue objects and close the original one with a comment linking to the newly created issues.
The text was updated successfully, but these errors were encountered:
What were you reviewing?
I was reviewing open issues related to the Participant module.
Relevant Link:
#67 #68
Feedback:
Both of these GitHub issue objects were bundles of multiple actual issues. Neither was addressed, and #67 had a comment that, while true, omitted the rest of the concerns being raised by the creator. If other commenters had continued to address just part of the concerns, the ticket might have been closed without addressing all the underlying problems. I've seen this happen in open-source projects.
Suggested Improvements:
On the one hand, when we create GitHub Issue objects, we should be careful to create coherent documents addressing well-scoped concerns rather than bundles that include many concerns.
However, we don't always perceive that the items we discuss should be separated. So, when we notice issues that involve several concerns, we should break them up into individual GitHub Issue objects and close the original one with a comment linking to the newly created issues.
The text was updated successfully, but these errors were encountered: