Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension slices should use camelCase identifiers. #95

Open
RadixSeven opened this issue Jan 4, 2025 · 1 comment
Open

Extension slices should use camelCase identifiers. #95

RadixSeven opened this issue Jan 4, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@RadixSeven
Copy link

Bug

The extension slices in NCPI Participant and NCPI Study Participant are named with kebab-case-identifiers. This is not the standard for FHIR.

FHIR fields from HL7 are named with lower camelCase. For example, Patient.birthDate and Patient.multipleBirth[x].

US core extension slices are named with camelCase. For example, US Core Ethnicity Extension.extension:ombCategory and US Core Race Extension.extension:ombCategory

Standard extensions from HL7 also use camelCase. For example, Person Recorded Sex Or Gender effectivePeriod

Expected behavior

Lower camelCase identifiers should also fill the url field of the slices in the extensions in the NCPI IG. For example, some slice names in Participant should be usCoreBirthSex, usCoreRace, and ageAtLastVitalStatus

@RadixSeven RadixSeven added the bug Something isn't working label Jan 4, 2025
@mingward
Copy link

mingward commented Jan 6, 2025

In the code (

* extension contains USCoreBirthSexExtension named us-core-birth-sex 0..1
* extension[us-core-birth-sex] ^short = "Sex assigned at birth (or pre-natal observed sex)"
* extension contains USCoreRaceExtension named us-core-race 0..1
* extension[us-core-race] ^short = "US Core Race"
* extension contains USCoreEthnicityExtension named us-core-ethnicity 0..1
* extension[us-core-ethnicity] ^short = "US Core Ethnicity"
* extension contains ResearchPopulation named population 0..1
* extension[population] ^short = "Population, Race, and/or Ethnicity information."
* extension contains ResearchDateOfBirthMethod named dob-method 0..1
* extension[dob-method] ^short = "Specifies method used to alter DOB for research sharing. Details should be available in the study protocols."
* extension contains AgeAtLastVitalStatus named age-at-last-vital-status 0..1
* extension[age-at-last-vital-status] ^short = "Age or date of last vital status"
):
Example, Eric pointed out that the FHIR convension on name and case:
Currently it has: CodeSystem: ResearchDataDateOfBirthMethod
FHIR's convesion of camelCase should be:
researchDataDateOfBirthMethod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants