Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that two different NCPI Participants (with two different ID) within the same study should be two different person #89

Open
mingward opened this issue Jan 3, 2025 · 1 comment
Assignees

Comments

@mingward
Copy link

mingward commented Jan 3, 2025

What were you reviewing?

In NCPI Participant profile:
https://nih-ncpi.github.io/ncpi-fhir-ig-2/StructureDefinition-ncpi-participant.html#profile

Is it true that ""two different NCPI Participants (with two different ID) within the same study should be two different individual"?
If so, how about adding this to the "id" description below so it is clear?
image

Currently it says "ParticipantID - Unique participant identifier". We think adding above will make the participant ID semantically unique within the same study. Thoughts? Thank you!

Relevant Link:

https://nih-ncpi.github.io/ncpi-fhir-ig-2/StructureDefinition-ncpi-participant.html#profile

@RobertJCarroll
Copy link

I'm not following where this change should be- it sounds like you are suggesting in the ID description, but I don't think that's appropriate as it's really a constraint on the entity. The ID is already stated to be unique.

To address this, I recommend we ensure that the descriptions for the resources are clear, minimally starting with including the details from the logical model. We could then supplement with more of these constraints if the language isn't clear enough for that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants