You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
45 minutes after I made some comments, someone released major changes. The pages I'd commented on were completely different. However, the version number was the same, and I saw no commits in GitHub.
Suggested Improvements:
It would help communication if we update the least significant version number each time there is a change to the main branch. It would make sense to not report 0.1.0 as the version for two significantly different revisions. The easiest way is to increase to 0.1.1, 0.1.2, ... 0.1.123, ... etc, each time we make changes. Then, it could be clear that a comment is about version 0.1.32 and people could look at history to find the appropriate version.
Review Date:
2024-10-30
The text was updated successfully, but these errors were encountered:
Thanks for the feedback! I suspect that we were making updates to the IG as you were reviewing. As this version of the IG is still early, we haven't begun versioning, but it's something the group will need to think through.
What were you reviewing?
I was reviewing the NCPI Participant module.
Relevant Link:
https://nih-ncpi.github.io/ncpi-fhir-ig-2/module_participant.html
Feedback:
45 minutes after I made some comments, someone released major changes. The pages I'd commented on were completely different. However, the version number was the same, and I saw no commits in GitHub.
Suggested Improvements:
It would help communication if we update the least significant version number each time there is a change to the main branch. It would make sense to not report 0.1.0 as the version for two significantly different revisions. The easiest way is to increase to 0.1.1, 0.1.2, ... 0.1.123, ... etc, each time we make changes. Then, it could be clear that a comment is about version 0.1.32 and people could look at history to find the appropriate version.
Review Date:
2024-10-30
The text was updated successfully, but these errors were encountered: