Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Feedback - Increment the least significant version number when there are changes #73

Open
RadixSeven opened this issue Oct 30, 2024 · 1 comment
Assignees
Labels
Participant Module Tasks or issues related to the Participant Module

Comments

@RadixSeven
Copy link

What were you reviewing?

I was reviewing the NCPI Participant module.

Relevant Link:

https://nih-ncpi.github.io/ncpi-fhir-ig-2/module_participant.html

Feedback:

45 minutes after I made some comments, someone released major changes. The pages I'd commented on were completely different. However, the version number was the same, and I saw no commits in GitHub.

Suggested Improvements:

It would help communication if we update the least significant version number each time there is a change to the main branch. It would make sense to not report 0.1.0 as the version for two significantly different revisions. The easiest way is to increase to 0.1.1, 0.1.2, ... 0.1.123, ... etc, each time we make changes. Then, it could be clear that a comment is about version 0.1.32 and people could look at history to find the appropriate version.

Review Date:

2024-10-30

@JamedFV JamedFV added the Participant Module Tasks or issues related to the Participant Module label Nov 15, 2024
@JamedFV
Copy link
Collaborator

JamedFV commented Nov 15, 2024

Thanks for the feedback! I suspect that we were making updates to the IG as you were reviewing. As this version of the IG is still early, we haven't begun versioning, but it's something the group will need to think through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Participant Module Tasks or issues related to the Participant Module
Projects
None yet
Development

No branches or pull requests

2 participants