Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Card Component adopt ConfigProvider for navigation #1344

Open
2 tasks
sandrahoang686 opened this issue Dec 19, 2024 · 2 comments
Open
2 tasks

Have Card Component adopt ConfigProvider for navigation #1344

sandrahoang686 opened this issue Dec 19, 2024 · 2 comments
Assignees
Labels
veda v2 VEDA Refactor Epic Work

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Dec 19, 2024

As the outcome from this PR #1338. We want to retain the LinkComponents for accessibility reasons instead of using a callback. We should update the Card component to adopt the ConfigProvider hooks to handle navigation.

Acceptance Criteria:

  • Data Catalog should be free of passing in LinkProperties
  • StoriesHub should be free from passing in LinkProperties
@vgeorge
Copy link
Contributor

vgeorge commented Jan 14, 2025

Status update: in #1374 we partially removed linkProperties from CatalogView, but component FeaturedSliderSection, used by the catalog, still uses the deprecated approach. I believe we need to address this in this ticket.

@vgeorge
Copy link
Contributor

vgeorge commented Jan 14, 2025

A possible side effect of these changes, raised by @aboydnw, is that Google Analytics events on instances relying on click events might not work as before now that cards are links. It would be nice to identify which instances are and track any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

No branches or pull requests

2 participants