Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Feature Request - Minor Bug with Sui Name Service Display #20409

Open
yjshi2015 opened this issue Nov 24, 2024 · 0 comments
Open

[Wallet] Feature Request - Minor Bug with Sui Name Service Display #20409

yjshi2015 opened this issue Nov 24, 2024 · 0 comments
Assignees

Comments

@yjshi2015
Copy link
Contributor

yjshi2015 commented Nov 24, 2024

Steps to Reproduce Issue

Currently, if a user sets a nickname in their wallet and subsequently applies for a domain name, the wallet interface does not display the domain name. This behavior can confuse users, as they may assume their domain name is not active. Moreover, there is no dedicated entry point in the wallet for users to view their applied domain name, which exacerbates the issue. This problem does not occur if the user has not set a nickname.

It can only be done as follows:

  1. delete the account and re-import it, but this is a very dangerous operation.

  2. Set the nickname to null value in the place of modifying the nickname, because the display priority is Nickname > Domain > Address, but this way may not be too friendly for common users.

const accountName = account?.nickname ?? domainName ?? formatAddress(account?.address || '');

Expected Result

Added a new UI entry point under the “EDIT NICKNAME” menu for users to view and manage their domain names.

When modifying nicknames, display the domain name, and users can choose whether to use the domain name or continue to use the nickname. like this:

image

Actual Result

image
@yjshi2015 yjshi2015 changed the title Sui Feature Request - Minor bug with domain display in wallet [Wallet] Feature Request - Minor Bug with Sui Name Service Display Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants