Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Snap] Masca #280

Closed
3 of 4 tasks
Montoya opened this issue Nov 9, 2023 · 3 comments
Closed
3 of 4 tasks

[Update Snap] Masca #280

Montoya opened this issue Nov 9, 2023 · 3 comments

Comments

@Montoya
Copy link
Contributor

Montoya commented Nov 9, 2023

Checklist

All items in the list below needs to be satisfied.

  • Is the summary of the change documented in this ticket?
  • Has a MetaMask Snaps team member reviewed whether the changes need to be vetted?
  • If there are changes that need to be vetted, attach a description and the relevant fixes/remediations to this issue.
  • The corresponding pull request in this repo has been merged.
@Montoya
Copy link
Contributor Author

Montoya commented Nov 9, 2023

Masca v1.1 release

Shasum [1.0.0]: nVKFpAn6RCNMM8UOH344F+tQUP6pxGjzisRXGBYf550=
Shasum [1.1.0]: lvNJQRx0yBScxfNkwkCnAtiRKSDkCkDlp3uMVBZXF7A=

Previous release: d8191bc7ed9e1a6c06811809ba1de0467319d3f5

New release: 40858f13e0d69cea26de2be4ab702cd8a204216d

Full diff:
blockchain-lab-um/masca@d8191bc...40858f1

Changes

  • Added signData RPC methods (supported for JWT and JWZ)
    • signData
    • PR
    • The RPC method takes as input either a type JWT or JWZ
      • In case of using type JWZ we use the provided data in JSON format and add the from field. After this, we use the 0xPolygonID/js-sdk library to package the data in JWZ format and also sign it (a ZKP is generated)
      • In case of using type JWT, user can provide header and payload fields that we use to construct a JWT and sign it. We also set the correct alg for signing and add fields like iss and kid.
  • Added getWalletId RPC method
    • getWalletId
    • PR
    • The RPC method calls snap_getEntropy without a salt and then uses HDNodeWallet from Ethers to create a wallet using the entropy and then returns the address of the created wallet

@Montoya
Copy link
Contributor Author

Montoya commented Nov 10, 2023

I have reviewed all the changes to the Snap source code

@FrederikBolding
Copy link
Member

Closing as this was done in #279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants