Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NonARModels #155

Open
kbrock opened this issue Jul 30, 2024 · 1 comment
Open

Remove NonARModels #155

kbrock opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request stale

Comments

@kbrock
Copy link
Member

kbrock commented Jul 30, 2024

Not sure why we need these changes, but they feel unrelated to virtual attributes.

May want to move this into the non-ar backed models.

This is at the top of virtual_fields

      module NonARModels
        def dangerous_attribute_method?(_); false; end
        def generated_association_methods; self; end
        def add_autosave_association_callbacks(*_args); self; end
        def belongs_to_required_by_default; false; end
      end

      included do
        unless respond_to?(:dangerous_attribute_method?)
          extend NonARModels
        end
      end
@kbrock kbrock added the enhancement New feature or request label Jul 30, 2024
@miq-bot miq-bot added the stale label Nov 1, 2024
@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants