From 602675142cdc39e494c79e2bcfe97767c297ce9b Mon Sep 17 00:00:00 2001
From: jazairi <16103405+jazairi@users.noreply.github.com>
Date: Tue, 20 Feb 2024 11:08:58 -0500
Subject: [PATCH] Add site title partial

Why these changes are being introduced:

The GeoData visual design includes a heading at the top of each
page, along with some descriptive text.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/GDT-182

How this addresses that need:

This adds the requested element as a partial, with conditional
copy for GDT versus non-GDT applications. It also moves the label text
to the `title` attribute, as the label is is now visually redundant but
may still be useful to screen reader users.

Side effects of this change:

* The input label before form submit is now the same as the placeholder
text. This feels fine since screen readers might not read placeholder
text, but they do consistently rely on labels.
* The copy for non-GDT titles did not come from UXWS and is subject
to change.
* The conditional title-in-nav has been removed from `site_nav`.
This seems superfluous since we now have h1 tags.
---
 app/assets/stylesheets/partials/_search.scss | 2 +-
 app/views/basic_search/index.html.erb        | 1 +
 app/views/layouts/_site_nav.html.erb         | 5 -----
 app/views/record/view.html.erb               | 1 +
 app/views/search/_form.html.erb              | 2 +-
 app/views/search/results.html.erb            | 2 ++
 app/views/shared/_site_title.html.erb        | 6 ++++++
 app/views/static/_forms.html.erb             | 2 +-
 8 files changed, 13 insertions(+), 8 deletions(-)
 create mode 100644 app/views/shared/_site_title.html.erb

diff --git a/app/assets/stylesheets/partials/_search.scss b/app/assets/stylesheets/partials/_search.scss
index cfba3f46..9683b0fd 100644
--- a/app/assets/stylesheets/partials/_search.scss
+++ b/app/assets/stylesheets/partials/_search.scss
@@ -6,7 +6,7 @@
 .basic-search {
   background-color: #989898;
   margin-bottom: 0rem;
-  padding: 1.6rem 2rem;
+  padding: 2.4rem 2rem 1rem 2.4rem;
 
   details {
     margin-top: 1rem;
diff --git a/app/views/basic_search/index.html.erb b/app/views/basic_search/index.html.erb
index 2d32e800..f79a07d0 100644
--- a/app/views/basic_search/index.html.erb
+++ b/app/views/basic_search/index.html.erb
@@ -1,6 +1,7 @@
 <%= content_for(:title, "Search | MIT Libraries") %>
 
 <div class="space-wrap">
+  <%= render partial: "shared/site_title" %>
   <%= render partial: "search/form" %>
   <%= render partial: "static/about" if ENV.fetch('ABOUT_APP', nil) %>
 </div>
diff --git a/app/views/layouts/_site_nav.html.erb b/app/views/layouts/_site_nav.html.erb
index 3ec1f9e9..87067840 100644
--- a/app/views/layouts/_site_nav.html.erb
+++ b/app/views/layouts/_site_nav.html.erb
@@ -1,10 +1,5 @@
 <div class="wrap-outer-header-local layout-band">
   <div class="wrap-header-local">
-    <% unless ENV['PLATFORM_NAME'] %>
-      <div class="local-identity">
-        <h2 class="title title-site"><a href="/">TIMDEX UI</a></h2>
-      </div>
-    <% end %>
     <div class="wrap-local-nav">
       <nav class="local-nav" aria-label="Main menu">
         <%= nav_link_to("Home", root_path) %>
diff --git a/app/views/record/view.html.erb b/app/views/record/view.html.erb
index 05e893f4..2889a8d0 100644
--- a/app/views/record/view.html.erb
+++ b/app/views/record/view.html.erb
@@ -2,6 +2,7 @@
 
 <%= render(partial: 'shared/error', collection: @errors) %>
 
+<%= render(partial: 'shared/site_title') %>
 <%= render(partial: 'search/form')%>
 
 <% if @record.nil? %>
diff --git a/app/views/search/_form.html.erb b/app/views/search/_form.html.erb
index f6dcf0c3..74b0d18f 100644
--- a/app/views/search/_form.html.erb
+++ b/app/views/search/_form.html.erb
@@ -19,7 +19,7 @@ end
 
 <form id="basic-search" class="form-horizontal basic-search" action="<%= results_path %>" method="get">
   <div class="form-group">
-    <label for="basic-search-main" class="field-label"><%= label %></label>
+    <label for="basic-search-main" class="field-label" title="<%= label %>" />
     <input id="basic-search-main" type="search" class="field field-text basic-search-input <%= "required" if search_required %>" name="q" placeholder="Enter your search" value="<%= params[:q] %>" <%= 'required="required" aria-required="true"' if search_required %>>
     <div class="basic-search-submit">
       <button type="submit" class="btn button-primary">Search</button>
diff --git a/app/views/search/results.html.erb b/app/views/search/results.html.erb
index 78d4500d..1b50b171 100644
--- a/app/views/search/results.html.erb
+++ b/app/views/search/results.html.erb
@@ -1,6 +1,8 @@
 <%= content_for(:title, "Search Results | MIT Libraries") %>
 
 <div class="space-wrap">
+
+  <%= render partial: "shared/site_title" %>
   <%= render partial: "form" %>
   <%= render partial: "search_summary" %>
 
diff --git a/app/views/shared/_site_title.html.erb b/app/views/shared/_site_title.html.erb
new file mode 100644
index 00000000..c6c6f02a
--- /dev/null
+++ b/app/views/shared/_site_title.html.erb
@@ -0,0 +1,6 @@
+<% if Flipflop.enabled?(:gdt) %>
+  <h1 class="hd-2">Search for Geographic/GIS data</h1>
+  <p>Find GIS data held at MIT and other universities</p>
+<% else %>
+  <h1 class="hd-2">Search the MIT Libraries</h1>
+<% end %>
diff --git a/app/views/static/_forms.html.erb b/app/views/static/_forms.html.erb
index b22601e6..4e6f1624 100644
--- a/app/views/static/_forms.html.erb
+++ b/app/views/static/_forms.html.erb
@@ -1,5 +1,5 @@
 <%
-  label = "Search the MIT Libraries"
+  label = "Enter your search"
   button = "Search"
 %>
 <form id="basic-search" class="form-horizontal basic-search" action="/results" method="get">