From 0363e5ddaa35db40f2ba6488cad367a688f2e580 Mon Sep 17 00:00:00 2001
From: Jeremy Prevost <JPrevost@users.noreply.github.com>
Date: Thu, 5 Oct 2023 11:22:04 -0400
Subject: [PATCH] Allow processors to reset publication error status

Why are these changes being introduced:

* There is no way in the application to reset a publication error
  status other than manually resaving each thesis that has errored.
  Until his point, we only had one or two errors per patch so this was
  not a huge problem. However, recently our vended DSpace ran out of
  disk space and rejected a batch of 40 theses. Rather than manually
  resetting each, we felt it was time to add the ability for processors
  to reset all errors to move them back to publication review.

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/ETD-638

How does this address that need:

* Creates a Thesis controller restricted to processors and above that
  changes all Theses with the error status to the review status
* Displays a link to reset publication errors on the view that shows
  the list of errors

Document any side effects to this change:
---
 app/controllers/thesis_controller.rb       |  8 +++
 app/models/ability.rb                      |  1 +
 app/views/thesis/select.html.erb           | 19 ++++++
 config/routes.rb                           |  2 +
 test/controllers/thesis_controller_test.rb | 77 ++++++++++++++++++++++
 test/fixtures/authors.yml                  |  8 +++
 test/fixtures/theses.yml                   | 14 ++++
 test/models/report_test.rb                 | 10 +--
 8 files changed, 134 insertions(+), 5 deletions(-)

diff --git a/app/controllers/thesis_controller.rb b/app/controllers/thesis_controller.rb
index 3b3710ac..54ae61eb 100644
--- a/app/controllers/thesis_controller.rb
+++ b/app/controllers/thesis_controller.rb
@@ -154,6 +154,14 @@ def proquest_export
     redirect_to thesis_proquest_export_preview_path
   end
 
+  def reset_all_publication_errors
+    Thesis.where(publication_status: 'Publication error').update(publication_status: 'Not ready for publication')
+
+    flash[:success] = 'Publication error statuses have been reset'
+
+    redirect_to thesis_select_path
+  end
+
   private
 
   # Various methods need to build an array of academic terms which meet varying conditions, in order to support a UI
diff --git a/app/models/ability.rb b/app/models/ability.rb
index 64689460..9260960e 100644
--- a/app/models/ability.rb
+++ b/app/models/ability.rb
@@ -85,6 +85,7 @@ def processor
     can :publish_to_dspace, Thesis
     can :proquest_export, Thesis
     can :proquest_export_preview, Thesis
+    can :reset_all_publication_errors, Thesis
     can :select, Thesis
 
     can :read, Transfer
diff --git a/app/views/thesis/select.html.erb b/app/views/thesis/select.html.erb
index d7c39ab6..3d9606ff 100644
--- a/app/views/thesis/select.html.erb
+++ b/app/views/thesis/select.html.erb
@@ -52,6 +52,18 @@
   </div>
 </div>
 
+<div id="reset-publication-errors"class="gridband" style="display: none;" aria-live="polite" role="region">
+  <div class="inline-action well">
+    <div class="message">
+      <h4 class="title">Ready to republish everything on this list?</h4>
+      <p>Once you have resolved any errors, you can reset this entire list.</p>
+    </div>
+    <div class="actions">
+        <%= link_to "Reset all errors to Publication Review", reset_all_publication_errors_path(:graduation => params[:graduation]), class: 'button button-primary' %>
+      </div>
+  </div>
+</div> 
+
 <script type="text/javascript">
 function applyFilter(table, _status) {
   // Update UI
@@ -67,6 +79,13 @@ function applyFilter(table, _status) {
   } else {
     $("#publish-to-dspace").attr('style', 'display: none;');
   }
+
+  // Reveal the "Reset errors panel if warranted"
+  if( 'Publication error' === _status ) {
+    $("#reset-publication-errors").attr('style', '');
+  } else {
+    $("#reset-publication-errors").attr('style', 'display: none;');
+  }
 }
 
 $(document).ready( function () {
diff --git a/config/routes.rb b/config/routes.rb
index b201eba1..7a8aee13 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -43,6 +43,8 @@
   get 'thesis/start', to: 'thesis#start', as: 'thesis_start'
   get 'thesis/proquest_export_preview', to: 'thesis#proquest_export_preview', as: 'thesis_proquest_export_preview'
   get 'thesis/proquest_export', to: 'thesis#proquest_export', as: 'thesis_proquest_export'
+  get 'thesis/reset_all_publication_errors', to: 'thesis#reset_all_publication_errors', as: 'reset_all_publication_errors'
+
   resources :registrar, only: [:new, :create, :show]
   resources :thesis, only: [:new, :create, :edit, :show, :update]
   get 'harvest', to: 'registrar#list_registrar', as: 'harvest'
diff --git a/test/controllers/thesis_controller_test.rb b/test/controllers/thesis_controller_test.rb
index 669e9c68..387c6716 100644
--- a/test/controllers/thesis_controller_test.rb
+++ b/test/controllers/thesis_controller_test.rb
@@ -887,4 +887,81 @@ def attach_files_to_records(tr, th)
     follow_redirect!
     assert_select '.alert-banner.warning', text: 'No theses are available to export.', count: 1
   end
+
+  # ~~~~~~~~~~~~~~~~~~~~~ resetting publishing error status ~~~~~~~~~~~~~~~~~~~~~
+  test 'anonymous users get redirected if they try to reset publishing errors' do
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count > 0
+
+    get reset_all_publication_errors_path
+    assert_response :redirect
+    assert_redirected_to '/login'
+
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count > 0
+  end
+
+  test 'basic users cannot reset publishing errors' do
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count > 0
+
+    sign_in users(:basic)
+    get reset_all_publication_errors_path
+    assert_redirected_to '/'
+    follow_redirect!
+    assert_select 'div.alert', text: 'Not authorized.', count: 1
+
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count > 0
+  end
+
+  test 'submitters cannot reset publishing errors' do
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count > 0
+
+    sign_in users(:transfer_submitter)
+    get reset_all_publication_errors_path
+    assert_redirected_to '/'
+    follow_redirect!
+    assert_select 'div.alert', text: 'Not authorized.', count: 1
+
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count > 0
+  end
+
+  test 'processors can reset publishing errors' do
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count > 0
+
+    sign_in users(:processor)
+    get reset_all_publication_errors_path
+    assert_redirected_to thesis_select_path
+
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count == 0
+  end
+
+  test 'thesis_admins can reset publishing errors' do
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count > 0
+
+    sign_in users(:thesis_admin)
+    get reset_all_publication_errors_path
+    assert_redirected_to thesis_select_path
+
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count == 0
+  end
+
+  test 'admins can reset publishing errors' do
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count > 0
+
+    sign_in users(:admin)
+    get reset_all_publication_errors_path
+    assert_redirected_to thesis_select_path
+    
+    error_count = Thesis.where(publication_status: 'Publication error').count
+    assert error_count == 0
+  end
 end
diff --git a/test/fixtures/authors.yml b/test/fixtures/authors.yml
index 28fb30fd..45de7c4f 100644
--- a/test/fixtures/authors.yml
+++ b/test/fixtures/authors.yml
@@ -170,3 +170,11 @@ twentysix:
   thesis: partial_proquest_wrong_term
   graduation_confirmed: true
   proquest_allowed: true
+
+pub_error_one:
+  user: yo
+  thesis: publication_error
+
+pub_error_too:
+  user: yo
+  thesis: publication_error_too
diff --git a/test/fixtures/theses.yml b/test/fixtures/theses.yml
index 237ad27f..a937a1b5 100644
--- a/test/fixtures/theses.yml
+++ b/test/fixtures/theses.yml
@@ -356,3 +356,17 @@ budget_report_multiple:
   departments: [one, two]
   dspace_handle: 1234/5678
   publication_status: Published
+
+publication_error:
+  title: Errors are fun
+  grad_date: 2023-09-01
+  degrees: [two]
+  departments: [one]
+  publication_status: 'Publication error'
+
+publication_error_too:
+  title: Errors are fun again
+  grad_date: 2023-09-01
+  degrees: [one]
+  departments: [two]
+  publication_status: 'Publication error'
diff --git a/test/models/report_test.rb b/test/models/report_test.rb
index 246b7035..3f592a49 100644
--- a/test/models/report_test.rb
+++ b/test/models/report_test.rb
@@ -24,7 +24,7 @@ class ReportTest < ActiveSupport::TestCase
     # This includes a row of all zeros, which could only have been generated by populate_category
     assert r.index_data['license'][3][:data].values.all? { |v| v == 0 }
     # Also check that a row with expected data is represented accurately
-    assert_equal r.index_data['license'][1][:data].values, [3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
+    assert_equal r.index_data['license'][1][:data].values, [3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
   end
 
   # pad_terms is a private method that gets called by each reporting row, to ensure that all rows have some value for
@@ -39,7 +39,7 @@ class ReportTest < ActiveSupport::TestCase
     returned_columns = r.index_data['summary'][3][:data].count
     assert_equal expected_terms, returned_columns
     # Test for a row of expected values
-    assert_equal r.index_data['summary'][3][:data].values, [0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0]
+    assert_equal r.index_data['summary'][3][:data].values, [0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0]
   end
 
   # ~~~~ Dashboard report
@@ -48,7 +48,7 @@ class ReportTest < ActiveSupport::TestCase
     result = r.index_data
     assert_equal Department.count, result['departments'].pluck(:label).length
     assert_includes result['departments'].pluck(:label), Department.first.name_dw
-    assert_equal result['departments'][0][:data].values, [0, 2, 0, 0, 0, 0, 0, 3, 0, 0, 1, 0, 0, 0]
+    assert_equal result['departments'][0][:data].values, [0, 2, 0, 0, 0, 0, 0, 3, 0, 0, 1, 0, 0, 0, 0]
   end
 
   test 'index includes summary data of authors not graduated' do
@@ -70,7 +70,7 @@ class ReportTest < ActiveSupport::TestCase
 
     r = Report.new
     result = r.index_data
-    assert_equal result['summary'][5][:data].values, [0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0]
+    assert_equal result['summary'][5][:data].values, [0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0]
   end
 
   test 'authors not graduated summary data dedups theses with multiple files' do
@@ -92,7 +92,7 @@ class ReportTest < ActiveSupport::TestCase
     r = Report.new
     result = r.index_data
     assert_not_equal result['summary'][5][:data].values, [0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
-    assert_equal result['summary'][5][:data].values, [0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
+    assert_equal result['summary'][5][:data].values, [0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
   end
 
   # ~~~~ Term detail report