Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globalize the state of the app #11

Open
LifeofMichal opened this issue Jan 7, 2020 · 0 comments
Open

Globalize the state of the app #11

LifeofMichal opened this issue Jan 7, 2020 · 0 comments
Assignees
@LifeofMichal
Labels
refactoring Just cleaning up code, no new features added.

Comments

@LifeofMichal
Copy link
Owner

LifeofMichal commented Jan 7, 2020 •
edited
Loading

At the moment MemeGenerator is responsible for performing the http request to fetch the memes data. In effect we're performing as many requests as many times as MemeGenerator is loaded, and that amount again every time app is reloaded.

The point of this ticket is to move the data fetching a level above in App.js
@LifeofMichal LifeofMichal self-assigned this Jan 10, 2020
@LifeofMichal LifeofMichal added the enhancement New feature or request label Jan 10, 2020
@LifeofMichal LifeofMichal added refactoring Just cleaning up code, no new features added. and removed enhancement New feature or request labels Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LifeofMichal LifeofMichal

Labels
refactoring Just cleaning up code, no new features added.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LifeofMichal