Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Wireless Terminal's Item Mode doesn't work #433

Open
ReiDaTecnologia opened this issue Nov 12, 2024 · 13 comments
Open

Universal Wireless Terminal's Item Mode doesn't work #433

ReiDaTecnologia opened this issue Nov 12, 2024 · 13 comments
Labels
bug Something isn't working

Comments

@ReiDaTecnologia
Copy link

ReiDaTecnologia commented Nov 12, 2024

Description

Right-clicking the Universal Wireless Terminal in Item Mode do nothing, this is because AE Additions isn't totally compatible with AE2 Extended Life. In my search i found this issue's comment which lead me to this PR then to this repository. Looks like zeng tried to PR the fix but after months waiting for it to be merged, he gave up and tried to do his own version of AE Addtions but then gave up as well? idk...
I tried compiling these versions but they either fail to even build or when they actually compile, the modpack crashes when launching.
Strangely, when reproducing this bug with only AE2 Extended Life and AE Additions, it don't create a crash-report, instead it just log the error in the console.
To Reproduce

Steps to reproduce the behavior:

  1. Build a basic wireless system to link the Universal Wireless Terminal
  2. Change the mode to Item
  3. Right-click for nothing to happen
  4. Check sonsole/log for the error/crash-report

Modpack version v1.46.0 but i also tested in the latest version (1.47.0)

debug.log or Crash report

1.46.0 crash report
1.47.0 crash report
AE2 Extended Life and AE Additions only debug.log

@Krutoy242
Copy link
Owner

Thanks for the report.
Im personally not playing with AE2 in my playthroughts, so i dont even know what "Universal Wireless Terminal" item is for. But what you described sounds like actual bug. Maybe one of solution would be just to remove and hide Universal Terminal.

@Krutoy242 Krutoy242 added the bug Something isn't working label Nov 13, 2024
@Krutoy242 Krutoy242 changed the title [Bug] Universal Wireless Terminal's Item Mode doesn't work Universal Wireless Terminal's Item Mode doesn't work Nov 13, 2024
@ReiDaTecnologia
Copy link
Author

ReiDaTecnologia commented Nov 13, 2024

so i dont even know what "Universal Wireless Terminal" item is for.

It is an item from AE Additions that allow you to combine all the wireless terminals (Item, Fluid and Gas) into one. Sneak + Right-click change between the modes, right-click open it.

Maybe one of solution would be just to remove and hide Universal Terminal

Well the other modes are still useful (Fluid and Gas) so i don't mind carrying with me two wireless terminals if you can't/don't know how to fix it. Wireless Crafting Terminal for items and the universal wireless for the rest.

@ReiDaTecnologia
Copy link
Author

Ok, after downloading the 1.12.2 code of AE Additions then applying the fix of zeng's PR, i was able to launch the modpack and test that the fix works. Here is the compiled jar file, the version is called "LOCAL" because AE Additions' code don't have the version set and is just set to "LOCAL", if you want, i can re-compile it with an appropriate version set (tell me if you want 1.3.8 or 1.3.9).

@Krutoy242
Copy link
Owner

I cannot compile the mod since I don't know how to do that.
Even if I can i would be unable to use it since it require to have dedicated mod installed, and i can only use mods from CurseForge.

Since you testd changes, was issue is actually fixed on this version?

@ReiDaTecnologia
Copy link
Author

Since you testd changes, was issue is actually fixed on this version?

Yes

@Krutoy242
Copy link
Owner

Ok. Then I can try to write Mixins for those functions, but I have no clue if i am able to add custom functions into the Java code. I don't see any possibilities to fix it another way.

@ReiDaTecnologia
Copy link
Author

Well i provided the compiled jar if you don't wanna use it, it's fine
Good luck with Mixins

@Krutoy242
Copy link
Owner

if you don't wanna use it

How I could use it? I wanna use it, i just don't know how.

@ReiDaTecnologia
Copy link
Author

How I could use it? I wanna use it, i just don't know how.

Replace the AE Additions jar with this one, it is the same thing but with the fix applied

@Krutoy242
Copy link
Owner

Krutoy242 commented Nov 14, 2024

Replace the AE Additions jar

But why I should replace jar on my computer, if I don't use Universal Wireless Terminal at all?

I mean, as a modpack maker, i care about players who need this patch, not me.
And how i can deliver fixed jar to players?

@ReiDaTecnologia
Copy link
Author

Well i think you remove AE Additions from being automatically downloaded from CF and instead insert this jar into the "overrides" folder, just like modified config files are embedded with the modpack

@Krutoy242
Copy link
Owner

jar into the "overrides" folder

This is impossible. CurseForge rejecting self-compiled Jars, disallow to upload modpack with custom jars.

@ReiDaTecnologia
Copy link
Author

Ok then i will leave the compiled jar in my google cloud for whoever want to download it to fix the issue on their side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants