Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Sun Lighting #2

Open
WhirligigGirl opened this issue Aug 2, 2019 · 0 comments
Open

Fix the Sun Lighting #2

WhirligigGirl opened this issue Aug 2, 2019 · 0 comments

Comments

@WhirligigGirl
Copy link

I'd like to suggest adding sunlight intensity curves and a brightness curve that reduces sunlight so that the intensity curve is 0 at 1 ki, and the lens flare is tiny beyond 1 Ki. Here's the patch I've been using: https://pastebin.com/z0eekYfH

There is a problem of course. If we use a very late patch or the FINAL patch, no one will be able to edit the sun intensity curve for their stock system mods. If we put it on FIRST or some other very early patch, existing intensity curve modifications for all stars will be broken.

I don't see this as much of a problem, though, since we already have several guidelines that must be followed to be IC compliant, like the SOI stuff and that star light shouldn't bleed outside the SOI. It shouldn't be too big of a deal for IC-compatible stars to just add a !IntensityCurve{} !IVAIntensityCurve{} etc before defining their own curves.

There needs to be some official stock sun support for the Interstellar Consortium, otherwise planet packs will have an additional and unnecessary sun in the sky, or multiple planet packs will be trying to patch out the sunlight, which could have unintended consequences.

For star system packs that follow IC guidelines don't actually require IC plugins on their own, but still need to patch the sunlight, they can add NEEDS[!InterstellarConsortium] to the patch that changes sunlight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant