-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On segmented images terminated atom groups or atoms are not included #107
Comments
Hi @alexey-krasnov , Thanks for bringing this to our attention we will look into this and get back to you with an update. Kind regards, |
Hey @alexey-krasnov, We have a bit of a dilemma here. The expansion is based on a connected object detection in the binarised and dilated image. If we use a bigger kernel for the dilation, we end up with the wrong inclusion of more objects around the structures. If we choose a smaller kernel, we get the problem that you have described above. In DECIMER-Image-Segmentation/decimer_segmentation
If you want to experiment with this, reduce the I hope this helps! |
Another approach that would probably work: In the function get_seeds in DECIMER-Image-Segmentation/decimer_segmentation
The purpose of this is to avoid the wrong inclusion of non-structural elements around the structures that might have been included in the original mask. If you delete the But again, this might lead to the wrong inclusion of elements in other cases. There is no simple way to create a function that works for all cases here. |
Hi @OBrink, thanks for the provided explanation! I checked both options separately and together. The best choice right now is only
which leads to more reasonable results with persisting the problem on some images though. It probably needs further checking with a variety of these parameters. Best regards, |
Hi guys,
There is a problem with the segmentation of some images when terminated atom groups or atoms are not included in segmented images. I tried to use both
expand
asTrue
andFalse
and even forexpand=False
it still cut out some atoms. Could you please provide any information about the origin of the problem and how to avoid it?Here is the output I got when using
vizualization=True
.Example output with
expand=True
:Example output with
expand=False
:The segmented saved files and original image are in the archive:
US-20220048929-A1_image_1674.zip
Best regards,
Aleksei
The text was updated successfully, but these errors were encountered: