Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making getproperty, getindex and iterate more type stable for Tangents #606

Open
ToucheSir opened this issue Mar 1, 2023 · 1 comment
Open
Labels
Structural Tangent Related to the `Tangent` type for structured (composite) values

Comments

@ToucheSir
Copy link
Contributor

Constprop is rarely able to pierce the function barrier and get through to the underlying type. This would especially help when the backing is a tuple or NamedTuple.

I think the main question is how to do this. @inline as seen in https://github.com/JuliaLang/julia/blob/master/base/tuple.jl is one option. Base.@constprop :aggressive is another that Diffractor currently employs.

@oxinabox oxinabox added the Structural Tangent Related to the `Tangent` type for structured (composite) values label Mar 1, 2023
@oxinabox
Copy link
Member

oxinabox commented Mar 1, 2023

Sounds good, if someone is interested in doing the experiments and working it out i would be happy to merge.
Not sure when I will get around to looking at it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Structural Tangent Related to the `Tangent` type for structured (composite) values
Projects
None yet
Development

No branches or pull requests

2 participants