We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello,
Looking at SenseHat.jl code, I noticed (for example)
SenseHat.jl/src/sensors.jl
Line 36 in a30a6cd
Maybe you should consider making use of type dispatch
abstract type AbstractSensor end struct HTS221 <: AbstractSensor end humidity() = humidity(HTS221())
Kind regards
PS : I didn't test code
The text was updated successfully, but these errors were encountered:
led_clear could simply be named clear
led_clear
clear
SenseHat.jl/src/led.jl
Line 138 in a30a6cd
sense = SenseHat() clear(sense.led)
Maybe you should also make use of setproperty! / getproperty
setproperty!
getproperty
Array(sense.led) # or sh.led.array ? sense.led.array = new_array # setproperty!
sense.led.gamma = new_gamma gamma = sh.led.gamma
Sorry, something went wrong.
No branches or pull requests
Hello,
Looking at SenseHat.jl code, I noticed (for example)
SenseHat.jl/src/sensors.jl
Line 36 in a30a6cd
Maybe you should consider making use of type dispatch
Kind regards
PS : I didn't test code
The text was updated successfully, but these errors were encountered: