Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add a concept of 'updates' to Blocks #24

Closed
2 tasks done
JoshuaKGoldberg opened this issue Dec 8, 2024 · 1 comment
Closed
2 tasks done

🚀 Feature: Add a concept of 'updates' to Blocks #24

JoshuaKGoldberg opened this issue Dec 8, 2024 · 1 comment
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request
Milestone
create-typescript...

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 8, 2024 •
edited
Loading

Bug Report Checklist

Overview

As mentioned in JoshuaKGoldberg/create-typescript-app#1181, Blocks need a way to signal updates. For example, a Knip block might change an existing knip.jsonc to knip.json.

Additional Info

I'd previously referred to this as Block migrations. But that's confusing overlap with the migration mode.

Linked issue on create-typescript-app: JoshuaKGoldberg/create-typescript-app#1753

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! 🙏 labels Dec 8, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 8, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🚀 Feature: Add a concept of 'migrations' to Blocks 🚀 Feature: Add a concept of 'updates' to Blocks Dec 13, 2024
@JoshuaKGoldberg
Copy link
Owner Author

I actually think this is a duplicate of #69. Blocks can have migrate() scripts that run commands like as rm old-config-file-format.config.*. So I'll just make sure all the migrations/updates I'd wanted are implemented in CTA in that way (JoshuaKGoldberg/create-typescript-app#1753). 👍

@JoshuaKGoldberg JoshuaKGoldberg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 31, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 31, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit to JoshuaKGoldberg/create-typescript-app that referenced this issue Dec 31, 2024
@JoshuaKGoldberg
chore: add remaining block migrations to migrate/update old repos (#1825
b180d18 
)

<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #1753
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Per JoshuaKGoldberg/create#24, uses the
existing `migrate()` functionality to let Blocks define how to update
from older versions or older tooling.

I've probably missed some config files that folks will discover in the
wild. But this more than covers all my personal repos' migrations.

💖
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request
Projects
None yet
Milestone
create-typescript-app Feature Parity
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg