Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: End-to-end migration test should run with --bin #1133

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 30, 2023 · 1 comment · Fixed by #1134
Closed
3 tasks done

🛠 Tooling: End-to-end migration test should run with --bin #1133

JoshuaKGoldberg opened this issue Dec 30, 2023 · 1 comment · Fixed by #1134
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

#1068 added a --bin option. But it didn't set up the migration end-to-end test to use --bin. Which means there's a discrepancy between some created files in that test and what the repo actually looks like. I'll send a PR in to fix this.

Additional Info

This kind of discrepancy is exactly what #546 -> #1048 is meant to fix. Sorry if this got in your way @Aslemammad!
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Dec 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 30, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 30, 2023
@JoshuaKGoldberg
chore: add --bin to migrate-test-e2e.js (#1134)
81a9f98 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1133
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds the corresponding `--bin` to migration.
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 30, 2023
Closed
3 tasks
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.50.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add --bin to migrate-test-e2e.js JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg