Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Testing: Use virtual file system in updateLocalFiles.test.ts #1118

Open
3 tasks done
JoshuaKGoldberg opened this issue Dec 27, 2023 · 0 comments
Open
3 tasks done
Labels
area: testing Improving how the repository's tests are run and/or code is tested status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

#1078 applied some improvements to how find-and-replaces via replace-in-file are applied to local files. At the time it was hard to unit test those changes because replace-in-file didn't support a "virtual" (in-memory) file system that tests could use to simulate reading & writing files. A couple of test snapshots now just have [Function] instead of testing what that function reads & writes:

But, good news! adamreisnz/replace-in-file#175 -> adamreisnz/replace-in-file#177 added support for that virtual fs to replace-in-file. So now the tests should be able to assert on the actual contents of files in memory by providing their own fs object!

Additional Info

I bet createJoshuaKGoldbergReplacement.test.ts could be improved by a virtual file system too...

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! area: testing Improving how the repository's tests are run and/or code is tested type: cleanup Tech debt or other code/repository cleanups labels Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing Improving how the repository's tests are run and/or code is tested status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Development

No branches or pull requests

1 participant