-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠 Tooling: Unnecessary commitType: docs in .all-contributorsrc #1090
Labels
area: tooling
Managing the repository's maintenance
status: accepting prs
Please, send a pull request to resolve this!
type: cleanup
Tech debt or other code/repository cleanups
Comments
JoshuaKGoldberg
added
good first issue
Good for newcomers, please hop on!
type: bug
Something isn't working :(
area: tooling
Managing the repository's maintenance
status: accepting prs
Please, send a pull request to resolve this!
type: cleanup
Tech debt or other code/repository cleanups
and removed
type: bug
Something isn't working :(
labels
Dec 11, 2023
Err, maybe |
|
3 tasks
JoshuaKGoldberg
added a commit
that referenced
this issue
Dec 30, 2023
## PR Checklist - [x] Addresses an existing open issue: fixes #1086 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Corrects the emojis and indentation in the `badgeTemplate` property. Also sets `commitType` manually per #1090 - leaving the issue open.
Ah, this was fixed by d789679. Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: tooling
Managing the repository's maintenance
status: accepting prs
Please, send a pull request to resolve this!
type: cleanup
Tech debt or other code/repository cleanups
Bug Report Checklist
main
branch of the repository.Overview
Thanks to #1048, we see now that this repository has two bits of tooling that are different between its 🍎 actual files and 🍌 code templates (see Additional Info below for explanation of the emojis):
"commitType": "docs"
:create-typescript-app/.all-contributorsrc
Line 367 in d66379b
"commitType": "docs"
:create-typescript-app/src/steps/writing/creation/writeAllContributorsRC.ts
Line 10 in d66379b
Docs for
commitType
are being added in all-contributors/all-contributors#710 -> all-contributors/all-contributors#757. Seems that the default value is"docs"
. So there's no need to explicitly specify it the way this repo has been.Let's remove any and all references to
commitType
from this repo. Accepting PRs!Additional Info
This repository is two things:
For the most part, the repository's end-to-end test for
--mode migration
makes sure that the 🍎 actual files and 🍌 code templates stay the same. As in, if one changes, the other needs to have the same change as well. But per #546, there are some files that were missed in that test. We're only now able to verify that they're the same as of #1048. That PR is where this discrepancy was discovered.The text was updated successfully, but these errors were encountered: