🛠 Tooling: Unnecessary --report-unused-disable-directives in templating

[JoshuaKGoldberg]

Bug Report Checklist

• I have tried restarting my IDE and the issue persists.
• I have pulled the latest main branch of the repository.
• I have searched for related issues and found none that matched my issue.

Overview

Thanks to #1048, we see now that this repository has two bits of tooling that are different between its 🍎 actual files and 🍌 code templates (see Additional Info below for explanation of the emojis):

• 🍎 Actual files: Does not use ESLint's --report-unused-disable-directives:

  create-typescript-app/package.json

  Line 28 in d66379b

  "lint": "eslint . .*js --max-warnings 0",

• 🍌 Code templates: Does have --report-unused-disable-directives:

  create-typescript-app/src/steps/writing/creation/writePackageJson.ts

  Line 81 in d66379b

  lint: "eslint . .*js --max-warnings 0 --report-unused-disable-directives",

There's no need for adding --report-unused-disable-directives in the lint script, because it's now used in the ESLint config file: https://github.com/JoshuaKGoldberg/create-typescript-app/blob/d66379b285b542a14d87c4f53cd0f0ccbc5310e9/.eslintrc.cjs#L149C1-L149C1

Let's remove any and all references to --report-unused-disable-directives from this repo. Accepting PRs!

Additional Info

This repository is two things:

• 🍎 An example of a working TypeScript repository, including builds, Knip, package publishing, and more tooling
• 🍌 Code that can set up a new or existing repository using all of that repository tooling

For the most part, the repository's end-to-end test for --mode migration makes sure that the 🍎 actual files and 🍌 code templates stay the same. As in, if one changes, the other needs to have the same change as well. But per #546, there are some files that were missed in that test. We're only now able to verify that they're the same as of #1048. That PR is where this discrepancy was discovered.

[github-actions]

🎉 This is included in version v1.49.3 🎉

The release is available on:

• GitHub releases
• npm package (@latest dist-tag)

Cheers! 📦🚀