Add support for event/job static dispatch calls on class itself

[JonasPardon]

Events

https://laravel.com/docs/9.x/events#dispatching-events

• EventClass::dispatch(...)
• EventClass::dispatchIf(...)
• EventClass::dispatchUnless(...)

Jobs

https://laravel.com/docs/9.x/queues#dispatching-jobs

• JobClass::dispatch(...)
• JobClass::dispatchIf(...)
• JobClass::dispatchUnless(...)
• JobClass::dispatchAfterResponse(...)
• JobClass::dispatchSync(...)

[ukkok]

I was looking into this and AFAIK this requires some changes to static call detection logic.

As these classes are now hardcoded into method, we would need get all imported classes and try to check if there is used these predefined methods?

[JonasPardon]

I was looking into this and AFAIK this requires some changes to static call detection logic.

As these classes are now hardcoded into method, we would need get all imported classes and try to check if there is used these predefined methods?

Sorry, I'm a bit confused by your sentence. You mean we would need to:

• Get all imported classes of the class we're currently checking
• Then check each of those imported classes separately for usages of one of the dispatch methods?

Or am I understanding it wrong?

[ukkok]

Maybe I should try to clarify my output, but what I meant was:

• As we now have these classes hardcoded in methods getDispatchedEvents and getDispatchedJobs this code tries to find usage of these classes & methods inside subscribers and related classes.
• To find jobs and events using this ClassName::dispatchsyntax, we need to have list of imported classes iterated through and then check have these defined methods been used

This is how far I have got with this reasoning. The problem here (I think) is that both event and jobs have dispatch method, which makes separating jobs and events a bit challenging.

[JonasPardon]

Alright I think I understand the issue.

A possible solution might be checking the dispatched class to see if they have a handle method, in which case they would be a Job, otherwise an Event. This however doesn't cover the case where a codebase has custom classes (that are not events or jobs) that have a static dispatch method, so they would be recognised as an Event.

Not sure if there's a more foolproof way though…