Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode for preferences page #1

Open
bbhtt opened this issue Aug 11, 2022 · 3 comments
Open

Dark mode for preferences page #1

bbhtt opened this issue Aug 11, 2022 · 3 comments

Comments

@bbhtt
Copy link

bbhtt commented Aug 11, 2022

Additionally it'd be great if it could adapt automatically based on browser/system theme

image

@Johennes
Copy link
Owner

It looks like this might be a bug in Firefox. The extension has the browser_style property set to true so the browser should color the page automatically. I'm not seeing a good way to fix this on the extension side so far but will keep on looking.

@bbhtt
Copy link
Author

bbhtt commented Aug 19, 2022

@Johennes
Copy link
Owner

I could use that to detect whether the theme uses dark mode. However, the issue is that the theme itself doesn't contain the right background color to use for the options page and even if I manually pick a color, a large chunk of the options page still stays white. I had described the issue in this SO question.

In light of these shortcomings, I'm leaning towards waiting for the fix in Firefox itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants