Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 64-bit integer values #36

Open
DavidDTA opened this issue Jan 27, 2022 · 3 comments
Open

Support 64-bit integer values #36

DavidDTA opened this issue Jan 27, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@DavidDTA
Copy link

DavidDTA commented Jan 27, 2022

The current code will only support 52-bit integers because that is the size of the elm Int type. However, the data format for firestore supports 64-bit integers, and we should preserve the serialized values.

This can be done using folkertdev/elm-int64 or malaire/elm-uint64.

@DavidDTA DavidDTA changed the title Support 64-bit integers in int fields Support 64-bit integer values Jan 27, 2022
@IzumiSy
Copy link
Owner

IzumiSy commented Jan 27, 2022

Thanks for your info! (but why have you closed this issue?)

@DavidDTA
Copy link
Author

I found myself confused by the firebase documentation, and I wasn't actually sure whether it supports 64-bit integers. It says it does, but if its interchange format is JSON, I don't think it really can.

@DavidDTA
Copy link
Author

Okay, I now see that int64 values are represented as strings under the hood.

It looks like this library could be expanded to allow decoding of more firestore types since right now it can not decode everything that could be stored. I don't have a use case for this right now, but I could open another issue if you would like me to.

@DavidDTA DavidDTA reopened this Jan 29, 2022
@IzumiSy IzumiSy added the enhancement New feature or request label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants