Scopes are broken in 4.1.0-Beta03

[Nek-12]

Your changes to scope resolution break them in 4.1.0-Beta03, 4.1.0-Beta01 working fine.

This code no longer functions:

internal fun destinationComponent(
    destination: Destination?,
    context: ComponentContext
): DestinationComponent = object : ComponentContext by context, DestinationComponent {
    override val scope = getKoin().getOrCreateScope(
        scopeId = destination?.getScopeId() ?: "RootComponent",
        qualifier = qualifier<DestinationScope>(),
        source = context as? DestinationScope
    )
    override val coroutineScope = coroutineScope()

    init {
        scope.declare(instance = coroutineScope, allowOverride = false)
        context.typed<DestinationScope>()?.let { scope.linkTo(it.scope) }
        doOnDestroy { scope.close() }
    }

    override fun equals(other: Any?): Boolean {
        if (other !is DestinationComponent) return false
        return scope.id == other.scope.id
    }

    override fun hashCode(): Int = scope.hashCode()
}

Coroutine scope is not properly added to the koin scope in the example above. Additionally, scope seems to not be properly preserved during recompositions.

[arnaudgiuliani]

Spotted. Fixing it with #2111

[arnaudgiuliani]

@Nek-12 could you help and give a try on 4.0.2-RC1?

[arnaudgiuliani]

Publishing 4.1.0-Beta4. You are welcome to open design suggestion in https://github.com/InsertKoinIO/KFIP/ if you see any interesting update to help the project 👍

[arnaudgiuliani]

@Nek-12 can you test 4.1.0-Beta5. this brings latest changes & fixes.