Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koin bom does not contain koin-core-jvm dependency #2092

Open
PokimonZerg opened this issue Dec 25, 2024 · 3 comments
Open

Koin bom does not contain koin-core-jvm dependency #2092

PokimonZerg opened this issue Dec 25, 2024 · 3 comments
Labels
status:checking currently in analysis - discussion or need more detailed specs type:issue type:tooling
Milestone

Comments

@PokimonZerg
Copy link

Describe the bug
io.insert-koim:koin-bom:4.0.1 does not contain koin-core-jvm dependency.
It is not good for maven users. They should specify koin-core-jvm version manually.
 
To Reproduce
Look inside the pom https://mvnrepository.com/artifact/io.insert-koin/koin-bom/4.0.1

Koin module and version:
io.insert-koim:koin-bom:4.0.1

@arnaudgiuliani arnaudgiuliani added the status:checking currently in analysis - discussion or need more detailed specs label Jan 9, 2025
@arnaudgiuliani
Copy link
Member

Just to understand here, is it just "koin-core-jvm" to add or is it about Kotlin tooling?

@PokimonZerg
Copy link
Author

I am investigating this issue. The problem is in the java-platform plugin and Kotlin Multiplatform plugin. Inside the Koin project, the java-platform plugin inserts the koin-core dependency into the resulting BOM. This is OK for Gradle. Gradle has a feature called variant aware dependency.

However, if you use the Koin BOM inside a Maven project, you will encounter an error. Maven does not have this feature, so you have to specify the version of koin-core-jvm manually. I think this is a minor issue, but I don't know how to fix it inside the Koin project.

For reference, the Ktor project also has a BOM. JetBrains uses some magic, so their BOM contains *-jvm dependencies.

@arnaudgiuliani
Copy link
Member

arnaudgiuliani commented Jan 15, 2025

Interesting, you are one of the rare maven users that tries such. Worth looking at JB Bom how they to help fix that 👍
If you have it under hand. Else I will check my self

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:checking currently in analysis - discussion or need more detailed specs type:issue type:tooling
Projects
None yet
Development

No branches or pull requests

2 participants