Skip to content
This repository has been archived by the owner on Aug 8, 2019. It is now read-only.

Assume items in pet inventory are always player-equippable. _wasEquipped no longer has a purpose. #769

Open
KennethShen opened this issue Jul 23, 2017 · 1 comment

Comments

@KennethShen
Copy link
Contributor

KennethShen commented Jul 23, 2017

_wasEquipped was originally created because pets could find items above the player item score. This was added to prevent players from equipping generated items while allowing player found items to be equipped. (Such as enchanted/blessed items and items from guardians and treasure .)

#185 capped guardian items to player score.
#205 changed Treasure chests to check player score.
Shops check player score before adding the item to the choice log
Protector pets allow previously equipped items to be equipped even after ascension.
#715 has capped Pet item score to player item score.
#751 now adds _wasEquipped to all items added to the choice log, even if they're sent directly to the pet.

Items in pet inventory can always be equipped by the player, removing the need for _wasEquipped.

@seiyria
Copy link
Member

seiyria commented Jul 23, 2017

Well-researched. Assuming nothing gets reverted then I think it's safe to remove the flag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants