Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defensive checks in get_file_by_id() #71

Closed
wibeasley opened this issue Jan 1, 2021 · 0 comments
Closed

defensive checks in get_file_by_id() #71

wibeasley opened this issue Jan 1, 2021 · 0 comments
Assignees
@wibeasley

Comments

@wibeasley
Copy link
Contributor

Building on @kuriwaki's work in #44, I'll add a few more checks and input validation to the function, since it's now the big workhorse of the package.
@wibeasley wibeasley self-assigned this Jan 1, 2021
wibeasley added a commit that referenced this issue Jan 2, 2021
@wibeasley
adding some more error messages & validation
2cfa95b 
ref #71
wibeasley added a commit that referenced this issue Jan 2, 2021
@wibeasley
make waterfall precedence clearer
a705eef 
ref #71
wibeasley added a commit that referenced this issue Jan 2, 2021
@wibeasley
closer inspection of parameters
b72f9a9 
ref #71
wibeasley added a commit that referenced this issue Jan 2, 2021
@wibeasley
remove unused "@import" roxygen commands
d5756e7 
Use `::` for all imported fxs

ref #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wibeasley wibeasley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wibeasley